Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: src/ia32/assembler-ia32-inl.h

Issue 7639020: Perform TODO(gc) cleanup for TODO-lockdown. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/gc
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ia32/assembler-ia32-inl.h
diff --git a/src/ia32/assembler-ia32-inl.h b/src/ia32/assembler-ia32-inl.h
index 5ddb9f7e7a110a1da572bbf80c5c6f146a90ef0e..9878fb4e41c61eb5e9f60cef2dd7d5728b7bdb98 100644
--- a/src/ia32/assembler-ia32-inl.h
+++ b/src/ia32/assembler-ia32-inl.h
@@ -94,7 +94,8 @@ void RelocInfo::set_target_address(Address target, Code* code) {
if (code != NULL && IsCodeTarget(rmode_)) {
Object* target_code = Code::GetCodeFromTargetAddress(target);
- // TODO(gc) We are not compacting code space.
+ // TODO(1550) We are passing NULL as a slot because code can never be on
+ // evacuation candidate.
code->GetHeap()->incremental_marking()->RecordWrite(
code, NULL, HeapObject::cast(target_code));
}
@@ -159,7 +160,8 @@ void RelocInfo::set_target_cell(JSGlobalPropertyCell* cell, Code* code) {
Memory::Address_at(pc_) = address;
CPU::FlushICache(pc_, sizeof(Address));
if (code != NULL) {
- // TODO(gc) We are not compacting cell space.
+ // TODO(1550) We are passing NULL as a slot because code can never be on
+ // evacuation candidate.
code->GetHeap()->incremental_marking()->RecordWrite(
code, NULL, cell);
}
« no previous file with comments | « src/heap-inl.h ('k') | src/ia32/code-stubs-ia32.cc » ('j') | src/mark-compact.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698