Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 758373002: Remove most of the old compositing code. (Closed)

Created:
6 years ago by ojan
Modified:
6 years ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove most of the old compositing code. This is all dead code. Just started with CompositedLayerMapping and deleted everything that touches it. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dffe66f77d6bf0d854e9ad7ba56b747d8bed62a9

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -4039 lines) Patch
M sky/engine/core/animation/CompositorAnimations.cpp View 2 chunks +6 lines, -43 lines 0 comments Download
M sky/engine/core/core.gni View 1 chunk +0 lines, -12 lines 0 comments Download
M sky/engine/core/frame/FrameView.h View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 6 chunks +0 lines, -51 lines 1 comment Download
M sky/engine/core/rendering/RenderBoxModelObject.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.cpp View 3 chunks +0 lines, -18 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 3 chunks +0 lines, -16 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 10 chunks +19 lines, -196 lines 2 comments Download
M sky/engine/core/rendering/RenderLayerClipper.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerModelObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderLayerRepainter.cpp View 3 chunks +2 lines, -18 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderSelectionInfo.h View 2 chunks +1 line, -10 lines 0 comments Download
M sky/engine/core/rendering/RenderTreeAsText.cpp View 2 chunks +0 lines, -13 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D sky/engine/core/rendering/compositing/CompositedLayerMapping.h View 1 chunk +0 lines, -390 lines 0 comments Download
D sky/engine/core/rendering/compositing/CompositedLayerMapping.cpp View 1 chunk +0 lines, -1803 lines 0 comments Download
D sky/engine/core/rendering/compositing/CompositingInputsUpdater.h View 1 chunk +0 lines, -61 lines 0 comments Download
D sky/engine/core/rendering/compositing/CompositingInputsUpdater.cpp View 1 chunk +0 lines, -180 lines 0 comments Download
D sky/engine/core/rendering/compositing/CompositingLayerAssigner.h View 1 chunk +0 lines, -94 lines 0 comments Download
D sky/engine/core/rendering/compositing/CompositingLayerAssigner.cpp View 1 chunk +0 lines, -237 lines 0 comments Download
D sky/engine/core/rendering/compositing/CompositingRequirementsUpdater.h View 1 chunk +0 lines, -69 lines 0 comments Download
D sky/engine/core/rendering/compositing/CompositingRequirementsUpdater.cpp View 1 chunk +0 lines, -390 lines 0 comments Download
D sky/engine/core/rendering/compositing/GraphicsLayerTreeBuilder.h View 1 chunk +0 lines, -57 lines 0 comments Download
D sky/engine/core/rendering/compositing/GraphicsLayerTreeBuilder.cpp View 1 chunk +0 lines, -96 lines 0 comments Download
D sky/engine/core/rendering/compositing/GraphicsLayerUpdater.h View 1 chunk +0 lines, -65 lines 0 comments Download
D sky/engine/core/rendering/compositing/GraphicsLayerUpdater.cpp View 1 chunk +0 lines, -130 lines 0 comments Download
M sky/engine/core/rendering/compositing/RenderLayerCompositor.cpp View 5 chunks +2 lines, -74 lines 0 comments Download
M sky/engine/web/LinkHighlight.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
ojan
https://codereview.chromium.org/758373002/diff/1/sky/engine/core/frame/FrameView.cpp File sky/engine/core/frame/FrameView.cpp (left): https://codereview.chromium.org/758373002/diff/1/sky/engine/core/frame/FrameView.cpp#oldcode462 sky/engine/core/frame/FrameView.cpp:462: void FrameView::gatherDebugLayoutRects(RenderObject* layoutRoot) Turns out this doesn't do anything ...
6 years ago (2014-11-26 04:42:05 UTC) #2
abarth-chromium
lgtm https://codereview.chromium.org/758373002/diff/1/sky/engine/core/rendering/RenderLayer.cpp File sky/engine/core/rendering/RenderLayer.cpp (right): https://codereview.chromium.org/758373002/diff/1/sky/engine/core/rendering/RenderLayer.cpp#newcode2368 sky/engine/core/rendering/RenderLayer.cpp:2368: return false; You should add a FIXME(sky) to ...
6 years ago (2014-11-26 04:45:20 UTC) #3
ojan
https://codereview.chromium.org/758373002/diff/1/sky/engine/core/rendering/RenderLayer.cpp File sky/engine/core/rendering/RenderLayer.cpp (right): https://codereview.chromium.org/758373002/diff/1/sky/engine/core/rendering/RenderLayer.cpp#newcode2368 sky/engine/core/rendering/RenderLayer.cpp:2368: return false; On 2014/11/26 04:45:20, abarth wrote: > You ...
6 years ago (2014-11-26 04:47:27 UTC) #4
ojan
6 years ago (2014-11-26 04:47:57 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
dffe66f77d6bf0d854e9ad7ba56b747d8bed62a9.

Powered by Google App Engine
This is Rietveld 408576698