Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: sky/engine/core/rendering/RenderLayerClipper.cpp

Issue 758373002: Remove most of the old compositing code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/rendering/RenderLayerClipper.cpp
diff --git a/sky/engine/core/rendering/RenderLayerClipper.cpp b/sky/engine/core/rendering/RenderLayerClipper.cpp
index d75d90cad867477757b2c04ecddb0ae0b0164726..1bb3f42eb84cb6078be9e6d65cda62dd19a5939f 100644
--- a/sky/engine/core/rendering/RenderLayerClipper.cpp
+++ b/sky/engine/core/rendering/RenderLayerClipper.cpp
@@ -322,11 +322,7 @@ void RenderLayerClipper::getOrCalculateClipRects(const ClipRectsContext& context
RenderLayer* RenderLayerClipper::clippingRootForPainting() const
{
const RenderLayer* current = m_renderer.layer();
- // FIXME: getting rid of current->hasCompositedLayerMapping() here breaks the
- // compositing/backing/no-backing-for-clip.html layout test, because there is a
- // "composited but paints into ancestor" layer involved. However, it doesn't make sense that
- // that check would be appropriate here but not inside the while loop below.
- if (current->isPaintInvalidationContainer() || current->hasCompositedLayerMapping())
+ if (current->isPaintInvalidationContainer())
return const_cast<RenderLayer*>(current);
while (current) {

Powered by Google App Engine
This is Rietveld 408576698