Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1827)

Unified Diff: sky/engine/core/rendering/RenderSelectionInfo.h

Issue 758373002: Remove most of the old compositing code. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/rendering/RenderSelectionInfo.h
diff --git a/sky/engine/core/rendering/RenderSelectionInfo.h b/sky/engine/core/rendering/RenderSelectionInfo.h
index 4196228e5da2e12a2de1b0f4541155fa6a7cf746..76674a222c4abd5ba7c01e250b94c76acbf81d99 100644
--- a/sky/engine/core/rendering/RenderSelectionInfo.h
+++ b/sky/engine/core/rendering/RenderSelectionInfo.h
@@ -65,9 +65,6 @@ public:
{
if (o->canUpdateSelectionOnRootLineBoxes()) {
m_rect = o->selectionRectForPaintInvalidation(m_paintInvalidationContainer, clipToVisibleContent);
- // FIXME: groupedMapping() leaks the squashing abstraction. See RenderBlockSelectionInfo for more details.
- if (m_paintInvalidationContainer && m_paintInvalidationContainer->layer()->groupedMapping())
- RenderLayer::mapRectToPaintBackingCoordinates(m_paintInvalidationContainer, m_rect);
} else {
m_rect = LayoutRect();
}
@@ -98,13 +95,7 @@ public:
void invalidatePaint()
{
- LayoutRect paintInvalidationRect = m_rects;
- // FIXME: this is leaking the squashing abstraction. However, removing the groupedMapping() condiitional causes
- // RenderBox::mapRectToPaintInvalidationBacking to get called, which makes rect adjustments even if you pass the same
- // paintInvalidationContainer as the render object. Find out why it does that and fix.
- if (m_paintInvalidationContainer && m_paintInvalidationContainer->layer()->groupedMapping())
- RenderLayer::mapRectToPaintBackingCoordinates(m_paintInvalidationContainer, paintInvalidationRect);
- m_object->invalidatePaintUsingContainer(m_paintInvalidationContainer, enclosingIntRect(paintInvalidationRect), InvalidationSelection);
+ m_object->invalidatePaintUsingContainer(m_paintInvalidationContainer, enclosingIntRect(m_rects), InvalidationSelection);
}
RenderBlock* block() const { return toRenderBlock(m_object); }

Powered by Google App Engine
This is Rietveld 408576698