Get rid of a lot of special code for RenderFlowThread invalidation.

Get rid of a lot of special code for RenderFlowThread invalidation.

Don't force a RenderFlowThread to become a paint invalidation container.
In fact, that should never happen.

What's still missing is to handle cases where an invalidation container
is inside the multicol container. That has never worked.

The NULL-check in LinkHighlight::attachLinkHighlightToCompositingLayer()
is no longer needed with this CL.

BUG=359877
R=chrishtr@chromium.org,jchaffraix@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186091

[chrishtr, 2014-11-25 22:45:47]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2014-11-25 22:45:48]

lgtm

[commit-bot: I haz the power, 2014-11-25 22:46:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/757933003/1

[commit-bot: I haz the power, 2014-11-26 00:54:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-26 00:54:34]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/38469)

[pdr., 2014-11-26 03:23:59]

On 2014/11/26 at 00:54:34, commit-bot wrote:
> Try jobs failed on following builders:
>   win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/38469)

I'm afraid these failures look real.

[mstensho (USE GERRIT), 2014-11-26 21:04:14]

On 2014/11/26 03:23:59, pdr wrote:
> On 2014/11/26 at 00:54:34, commit-bot wrote:
> > Try jobs failed on following builders:
> >   win_blink_rel on tryserver.blink
>
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/38469)
> 
> I'm afraid these failures look real.

Yeah, I kind of forgot that different platforms have different fonts (obviously
not an issue in reftest land, where I usually live). :-p Ahem!

Fixed that.

I think there were some unrelated failures / flakes too. Let's see if they just
disappear when we try again.

[pdr., 2014-11-26 21:34:37]

On 2014/11/26 at 21:04:14, mstensho wrote:
> On 2014/11/26 03:23:59, pdr wrote:
> > On 2014/11/26 at 00:54:34, commit-bot wrote:
> > > Try jobs failed on following builders:
> > >   win_blink_rel on tryserver.blink
> >
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/38469)
> > 
> > I'm afraid these failures look real.
> 
> Yeah, I kind of forgot that different platforms have different fonts
(obviously not an issue in reftest land, where I usually live). :-p Ahem!
> 
> Fixed that.
> 
> I think there were some unrelated failures / flakes too. Let's see if they
just disappear when we try again.

In my experience, Ahem hasn't been as platform neutral as I would like. You may
have better experience with these tests since you don't have any text though.
Fingers crossed this tryrun works :)

[mstensho (USE GERRIT), 2014-11-27 06:09:04]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2014-11-27 06:09:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/757933003/20001

[commit-bot: I haz the power, 2014-11-27 06:54:59]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186091

[mstensho (USE GERRIT), 2014-11-27 09:38:17]

On 2014/11/26 21:34:37, pdr wrote:
> In my experience, Ahem hasn't been as platform neutral as I would like. You
may
> have better experience with these tests since you don't have any text though.
> Fingers crossed this tryrun works :)

I'm no big fan of Ahem, because, like you stated, it's not completely
trustworthy, and it causes more unreadable test cases, in my opinion. But I saw
no other option here, especially with the test that actually adds text
dynamically.

Thanks to your fingers crossed, this went through. :)