Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Unified Diff: Source/core/rendering/RenderRegion.cpp

Issue 757933003: Get rid of a lot of special code for RenderFlowThread invalidation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Ahemify and pxify tests. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderRegion.h ('k') | Source/web/LinkHighlight.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderRegion.cpp
diff --git a/Source/core/rendering/RenderRegion.cpp b/Source/core/rendering/RenderRegion.cpp
index 531fbaafd0cf60b9a09eda6bba4ed3051d3c4009..74559775b4f1b646a091e7f54e4d9fcd158c8179 100644
--- a/Source/core/rendering/RenderRegion.cpp
+++ b/Source/core/rendering/RenderRegion.cpp
@@ -119,30 +119,6 @@ void RenderRegion::layoutBlock(bool relayoutChildren)
// RenderFlowThread itself).
}
-void RenderRegion::paintInvalidationOfFlowThreadContentRectangle(const LayoutRect& paintInvalidationRect, const LayoutRect& flowThreadPortionRect, const LayoutRect& flowThreadPortionOverflowRect, const LayoutPoint& regionLocation)
-{
- ASSERT(isValid());
-
- // We only have to issue a paint invalidation in this region if the region rect intersects the paint invalidation rect.
- LayoutRect flippedFlowThreadPortionRect(flowThreadPortionRect);
- LayoutRect flippedFlowThreadPortionOverflowRect(flowThreadPortionOverflowRect);
- flowThread()->flipForWritingMode(flippedFlowThreadPortionRect); // Put the region rects into physical coordinates.
- flowThread()->flipForWritingMode(flippedFlowThreadPortionOverflowRect);
-
- LayoutRect clippedRect(paintInvalidationRect);
- clippedRect.intersect(flippedFlowThreadPortionOverflowRect);
- if (clippedRect.isEmpty())
- return;
-
- // Put the region rect into the region's physical coordinate space.
- clippedRect.setLocation(regionLocation + (clippedRect.location() - flippedFlowThreadPortionRect.location()));
-
- // Now switch to the region's writing mode coordinate space and let it issue paint invalidations itself.
- flipForWritingMode(clippedRect);
-
- invalidatePaintRectangle(clippedRect);
-}
-
void RenderRegion::computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, LayoutUnit& maxLogicalWidth) const
{
if (!isValid()) {
« no previous file with comments | « Source/core/rendering/RenderRegion.h ('k') | Source/web/LinkHighlight.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698