Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: Source/core/rendering/RenderFlowThread.h

Issue 757933003: Get rid of a lot of special code for RenderFlowThread invalidation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Ahemify and pxify tests. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderFlowThread.h
diff --git a/Source/core/rendering/RenderFlowThread.h b/Source/core/rendering/RenderFlowThread.h
index 74a6b9cb50c34fa38658469ba0c5b208af1935e2..b77c57c3dc5a0582520343f10a43c90ad7ffd042 100644
--- a/Source/core/rendering/RenderFlowThread.h
+++ b/Source/core/rendering/RenderFlowThread.h
@@ -61,6 +61,8 @@ public:
virtual bool isRenderMultiColumnFlowThread() const { return false; }
virtual bool isRenderPagedFlowThread() const { return false; }
+ virtual bool supportsPaintInvalidationStateCachedOffsets() const override { return false; }
+
virtual void layout() override;
// Always create a RenderLayer for the RenderFlowThread so that we
@@ -82,7 +84,7 @@ public:
void invalidateRegions();
bool hasValidRegionInfo() const { return !m_regionsInvalidated && !m_multiColumnSetList.isEmpty(); }
- void paintInvalidationRectangleInRegions(const LayoutRect&) const;
+ virtual void mapRectToPaintInvalidationBacking(const RenderLayerModelObject* paintInvalidationContainer, LayoutRect&, const PaintInvalidationState*) const override;
LayoutUnit pageLogicalHeightForOffset(LayoutUnit);
LayoutUnit pageRemainingLogicalHeightForOffset(LayoutUnit, PageBoundaryRule = IncludePageBoundary);
@@ -102,7 +104,7 @@ public:
bool pageLogicalSizeChanged() const { return m_pageLogicalSizeChanged; }
void collectLayerFragments(LayerFragments&, const LayoutRect& layerBoundingBox, const LayoutRect& dirtyRect);
- LayoutRect fragmentsBoundingBox(const LayoutRect& layerBoundingBox);
+ LayoutRect fragmentsBoundingBox(const LayoutRect& layerBoundingBox) const;
LayoutPoint flowThreadPointToVisualPoint(const LayoutPoint& flowThreadPoint) const
{
@@ -120,7 +122,6 @@ protected:
virtual const char* renderName() const = 0;
void updateRegionsFlowThreadPortionRect();
- bool shouldIssuePaintInvalidations(const LayoutRect&) const;
virtual RenderMultiColumnSet* columnSetAtBlockOffset(LayoutUnit) const = 0;
« no previous file with comments | « LayoutTests/fast/repaint/multicol-with-text-expected.txt ('k') | Source/core/rendering/RenderFlowThread.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698