Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Unified Diff: Source/core/rendering/RenderObject.cpp

Issue 757933003: Get rid of a lot of special code for RenderFlowThread invalidation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Ahemify and pxify tests. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderObject.h ('k') | Source/core/rendering/RenderRegion.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderObject.cpp
diff --git a/Source/core/rendering/RenderObject.cpp b/Source/core/rendering/RenderObject.cpp
index 3c69a674bc9d1dcc29febf6c95dd32687dc4a7c1..6b9956c96b59275ba3056b8292813e4fa363c583 100644
--- a/Source/core/rendering/RenderObject.cpp
+++ b/Source/core/rendering/RenderObject.cpp
@@ -1062,16 +1062,6 @@ const RenderLayerModelObject* RenderObject::enclosingCompositedContainer() const
const RenderLayerModelObject* RenderObject::adjustCompositedContainerForSpecialAncestors(const RenderLayerModelObject* paintInvalidationContainer) const
{
- // If we have a flow thread, then we need to do individual paint invalidations within the RenderRegions instead.
- // Return the flow thread as a paint invalidation container in order to create a chokepoint that allows us to change
- // paint invalidation to do individual region paint invalidations.
- if (RenderFlowThread* parentRenderFlowThread = flowThreadContainingBlock()) {
- // If we have already found a paint invalidation container then we will invalidate paints in that container only if it is part of the same
- // flow thread. Otherwise we will need to catch the paint invalidation call and send it to the flow thread.
- if (!paintInvalidationContainer || paintInvalidationContainer->flowThreadContainingBlock() != parentRenderFlowThread)
- paintInvalidationContainer = parentRenderFlowThread;
- }
-
if (paintInvalidationContainer)
return paintInvalidationContainer;
@@ -1139,11 +1129,6 @@ void RenderObject::invalidatePaintUsingContainer(const RenderLayerModelObject* p
"object", this->debugName().ascii(),
"info", jsonObjectForPaintInvalidationInfo(r, paintInvalidationReasonToString(invalidationReason)));
- if (paintInvalidationContainer->isRenderFlowThread()) {
- toRenderFlowThread(paintInvalidationContainer)->paintInvalidationRectangleInRegions(r);
- return;
- }
-
if (paintInvalidationContainer->isRenderView()) {
toRenderView(paintInvalidationContainer)->invalidatePaintForRectangle(r, invalidationReason);
return;
@@ -2040,21 +2025,16 @@ FloatPoint RenderObject::localToInvalidationBackingPoint(const LayoutPoint& loca
{
const RenderLayerModelObject* paintInvalidationContainer = containerForPaintInvalidation();
ASSERT(paintInvalidationContainer);
- RenderLayer* layer = paintInvalidationContainer->layer();
- ASSERT(layer);
+ ASSERT(paintInvalidationContainer->layer());
+ ASSERT(paintInvalidationContainer->layer()->compositingState() != NotComposited);
if (backingLayer)
- *backingLayer = layer;
+ *backingLayer = paintInvalidationContainer->layer();
FloatPoint containerPoint = localToContainerPoint(FloatPoint(localPoint), paintInvalidationContainer, TraverseDocumentBoundaries);
-
- if (layer->compositingState() == NotComposited) // This can happen for RenderFlowThread.
- return containerPoint;
-
RenderLayer::mapPointToPaintBackingCoordinates(paintInvalidationContainer, containerPoint);
return containerPoint;
}
-
LayoutSize RenderObject::offsetFromContainer(const RenderObject* o, const LayoutPoint& point, bool* offsetDependsOnPoint) const
{
ASSERT(o == container());
« no previous file with comments | « Source/core/rendering/RenderObject.h ('k') | Source/core/rendering/RenderRegion.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698