Remove deprecated v8::External::New calls (blink side)

Remove deprecated v8::External::New calls (blink side)

BUG=266838
R=dcarney@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162193

[dcarney, 2013-11-18 10:42:23]

lgtm

[haraken, 2013-11-18 10:42:47]

LGTM

https://codereview.chromium.org/75163003/diff/1/Source/bindings/templates/int...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/75163003/diff/1/Source/bindings/templates/int...
Source/bindings/templates/interface.cpp:210:
functionTemplate->SetNativeDataProperty(v8::String::NewSymbol("{{attribute.name}}"),
{{getter_callback_name}}, {{attribute.setter_callback_name}},
v8::External::New(isolate, 0), static_cast<v8::PropertyAttribute>(v8::None),
v8::Handle<v8::AccessorSignature>(),
static_cast<v8::AccessControl>(v8::DEFAULT));

nbarth: Probably can you remove this file from the code base? I think we only
use Jinja templates in bindings/unstable/.

[Nils Barth (inactive), 2013-11-18 10:47:25]

(Reply to haraken)

https://codereview.chromium.org/75163003/diff/1/Source/bindings/templates/int...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/75163003/diff/1/Source/bindings/templates/int...
Source/bindings/templates/interface.cpp:210:
functionTemplate->SetNativeDataProperty(v8::String::NewSymbol("{{attribute.name}}"),
{{getter_callback_name}}, {{attribute.setter_callback_name}},
v8::External::New(isolate, 0), static_cast<v8::PropertyAttribute>(v8::None),
v8::Handle<v8::AccessorSignature>(),
static_cast<v8::AccessControl>(v8::DEFAULT));
On 2013/11/18 10:42:48, haraken wrote:
> nbarth: Probably can you remove this file from the code base? I think we only
> use Jinja templates in bindings/unstable/.

? I don't understand.
Jinja templates are in bindings/templates/
Python scripts are in bindings/unstable/
Which file do you suggest we remove?

[commit-bot: I haz the power, 2013-11-18 10:49:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/75163003/1

[haraken, 2013-11-18 10:50:54]

> ? I don't understand.
> Jinja templates are in bindings/templates/
> Python scripts are in bindings/unstable/
> Which file do you suggest we remove?

ah, sorry, ignore my comment. I have another templates/ directory locally and
was confused :)

[Nils Barth (inactive), 2013-11-18 10:53:49]

On 2013/11/18 10:50:54, haraken wrote:
> ah, sorry, ignore my comment. I have another templates/ directory locally and
> was confused :)

n/p! (^.-)b

[commit-bot: I haz the power, 2013-11-18 11:48:24]

Change committed as 162193