Source/bindings/v8/PageScriptDebugServer.cpp - Issue 75163003: Remove deprecated v8::External::New calls (blink side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/PageScriptDebugServer.cpp

Issue 75163003: Remove deprecated v8::External::New calls (blink side) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/PageScriptDebugServer.cpp

diff --git a/Source/bindings/v8/PageScriptDebugServer.cpp b/Source/bindings/v8/PageScriptDebugServer.cpp

index ed4d52261e2ab58f25515aacc5d47639ac453881..48b879b49604657e5ba57b731df4a697520224f3 100644

--- a/Source/bindings/v8/PageScriptDebugServer.cpp

+++ b/Source/bindings/v8/PageScriptDebugServer.cpp

@@ -102,7 +102,7 @@ void PageScriptDebugServer::addListener(ScriptDebugListener* listener, Page* pag

if (!m_listenersMap.size()) {

ensureDebuggerScriptCompiled();

ASSERT(!debuggerScript->IsUndefined());

- v8::Debug::SetDebugEventListener2(&PageScriptDebugServer::v8DebugEventCallback, v8::External::New(this));

+ v8::Debug::SetDebugEventListener2(&PageScriptDebugServer::v8DebugEventCallback, v8::External::New(m_isolate, this));

}

m_listenersMap.set(page, listener);