Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: Source/bindings/v8/V8DOMConfiguration.h

Issue 75163003: Remove deprecated v8::External::New calls (blink side) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/V8DOMConfiguration.h
diff --git a/Source/bindings/v8/V8DOMConfiguration.h b/Source/bindings/v8/V8DOMConfiguration.h
index 711d86bf838721675961f2dfe3b295d5d7da521e..aed41bbf82487f43cfe6299e3a5ad1d541f64dff 100644
--- a/Source/bindings/v8/V8DOMConfiguration.h
+++ b/Source/bindings/v8/V8DOMConfiguration.h
@@ -72,18 +72,18 @@ public:
static void installAttributes(v8::Handle<v8::ObjectTemplate>, v8::Handle<v8::ObjectTemplate>, const AttributeConfiguration*, size_t attributeCount, v8::Isolate*, WrapperWorldType currentWorldType);
template<class ObjectOrTemplate>
- static inline void installAttribute(v8::Handle<ObjectOrTemplate> instanceTemplate, v8::Handle<ObjectOrTemplate> prototype, const AttributeConfiguration& attribute, v8::Isolate*)
+ static inline void installAttribute(v8::Handle<ObjectOrTemplate> instanceTemplate, v8::Handle<ObjectOrTemplate> prototype, const AttributeConfiguration& attribute, v8::Isolate* isolate)
{
(attribute.onPrototype ? prototype : instanceTemplate)->SetAccessor(v8::String::NewSymbol(attribute.name),
attribute.getter,
attribute.setter,
- v8::External::New(const_cast<WrapperTypeInfo*>(attribute.data)),
+ v8::External::New(isolate, const_cast<WrapperTypeInfo*>(attribute.data)),
attribute.settings,
attribute.attribute);
}
template<class ObjectOrTemplate>
- static inline void installAttribute(v8::Handle<ObjectOrTemplate> instanceTemplate, v8::Handle<ObjectOrTemplate> prototype, const AttributeConfiguration& attribute, v8::Isolate*, WrapperWorldType currentWorldType)
+ static inline void installAttribute(v8::Handle<ObjectOrTemplate> instanceTemplate, v8::Handle<ObjectOrTemplate> prototype, const AttributeConfiguration& attribute, v8::Isolate* isolate, WrapperWorldType currentWorldType)
{
v8::AccessorGetterCallback getter = attribute.getter;
v8::AccessorSetterCallback setter = attribute.setter;
@@ -96,7 +96,7 @@ public:
(attribute.onPrototype ? prototype : instanceTemplate)->SetAccessor(v8::String::NewSymbol(attribute.name),
getter,
setter,
- v8::External::New(const_cast<WrapperTypeInfo*>(attribute.data)),
+ v8::External::New(isolate, const_cast<WrapperTypeInfo*>(attribute.data)),
attribute.settings,
attribute.attribute);
}

Powered by Google App Engine
This is Rietveld 408576698