Source/bindings/v8/ScriptDebugServer.cpp - Issue 75163003: Remove deprecated v8::External::New calls (blink side)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptDebugServer.cpp

Issue 75163003: Remove deprecated v8::External::New calls (blink side) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ScriptDebugServer.cpp

diff --git a/Source/bindings/v8/ScriptDebugServer.cpp b/Source/bindings/v8/ScriptDebugServer.cpp

index b94fadf396ba83af4b46c387cb8327638f76a40f..c20f1de0628dfee4fbb9fedd1cb12f1217cc407a 100644

--- a/Source/bindings/v8/ScriptDebugServer.cpp

+++ b/Source/bindings/v8/ScriptDebugServer.cpp

@@ -191,7 +191,7 @@ void ScriptDebugServer::breakProgram()

v8::HandleScope scope(m_isolate);

if (m_breakProgramCallbackTemplate.isEmpty()) {

v8::Handle<v8::FunctionTemplate> templ = v8::FunctionTemplate::New();

- templ->SetCallHandler(&ScriptDebugServer::breakProgramCallback, v8::External::New(this));

+ templ->SetCallHandler(&ScriptDebugServer::breakProgramCallback, v8::External::New(m_isolate, this));

m_breakProgramCallbackTemplate.set(m_isolate, templ);

}