Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: Source/bindings/v8/V8DOMConfiguration.cpp

Issue 75163003: Remove deprecated v8::External::New calls (blink side) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/V8DOMConfiguration.cpp
diff --git a/Source/bindings/v8/V8DOMConfiguration.cpp b/Source/bindings/v8/V8DOMConfiguration.cpp
index 0dce9e56d0ea0d6af33e4ddd83636aa704ced383..100951f6f45a6bc38c7cc9c37380fb1d593f12fd 100644
--- a/Source/bindings/v8/V8DOMConfiguration.cpp
+++ b/Source/bindings/v8/V8DOMConfiguration.cpp
@@ -53,12 +53,12 @@ void V8DOMConfiguration::installAccessors(v8::Handle<v8::ObjectTemplate> prototy
v8::Local<v8::FunctionTemplate> getter;
if (getterCallback) {
- getter = v8::FunctionTemplate::New(getterCallback, v8::External::New(const_cast<WrapperTypeInfo*>(accessors[i].data)), signature, 0);
+ getter = v8::FunctionTemplate::New(getterCallback, v8::External::New(isolate, const_cast<WrapperTypeInfo*>(accessors[i].data)), signature, 0);
getter->RemovePrototype();
}
v8::Local<v8::FunctionTemplate> setter;
if (setterCallback) {
- setter = v8::FunctionTemplate::New(setterCallback, v8::External::New(const_cast<WrapperTypeInfo*>(accessors[i].data)), signature, 1);
+ setter = v8::FunctionTemplate::New(setterCallback, v8::External::New(isolate, const_cast<WrapperTypeInfo*>(accessors[i].data)), signature, 1);
setter->RemovePrototype();
}
prototype->SetAccessorProperty(v8::String::NewSymbol(accessors[i].name), getter, setter, accessors[i].attribute, accessors[i].settings);

Powered by Google App Engine
This is Rietveld 408576698