Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: Source/bindings/v8/V8EventListenerList.h

Issue 75163003: Remove deprecated v8::External::New calls (blink side) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 98
99 v8::Local<v8::Object> object = v8::Local<v8::Object>::Cast(value); 99 v8::Local<v8::Object> object = v8::Local<v8::Object>::Cast(value);
100 v8::Handle<v8::String> wrapperProperty = getHiddenProperty(isAttribute, isol ate); 100 v8::Handle<v8::String> wrapperProperty = getHiddenProperty(isAttribute, isol ate);
101 101
102 V8EventListener* wrapper = doFindWrapper(object, wrapperProperty, isolate); 102 V8EventListener* wrapper = doFindWrapper(object, wrapperProperty, isolate);
103 if (wrapper) 103 if (wrapper)
104 return wrapper; 104 return wrapper;
105 105
106 RefPtr<V8EventListener> wrapperPtr = WrapperType::create(object, isAttribute , isolate); 106 RefPtr<V8EventListener> wrapperPtr = WrapperType::create(object, isAttribute , isolate);
107 if (wrapperPtr) 107 if (wrapperPtr)
108 object->SetHiddenValue(wrapperProperty, v8::External::New(wrapperPtr.get ())); 108 object->SetHiddenValue(wrapperProperty, v8::External::New(isolate, wrapp erPtr.get()));
109 109
110 return wrapperPtr; 110 return wrapperPtr;
111 } 111 }
112 112
113 } // namespace WebCore 113 } // namespace WebCore
114 114
115 #endif // V8EventListenerList_h 115 #endif // V8EventListenerList_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698