Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 744723002: remove some calls to to-be-deprecated v8::Value::To* functions (Closed)

Created:
6 years, 1 month ago by dcarney
Modified:
6 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin (slow to review), extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

remove some calls to to-be-deprecated v8::Value::To* functions TBR=eroman@chromium.org, kalman@chromium.org, jamesr@chromium.org BUG= Committed: https://crrev.com/a261b771b94ccf7bb63f932b0adc8b7f2dc2e946 Cr-Commit-Position: refs/heads/master@{#305034}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -71 lines) Patch
M chrome/renderer/benchmarking_extension.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/enterprise_platform_keys_natives.cc View 1 2 1 chunk +3 lines, -6 lines 0 comments Download
M content/renderer/chrome_object_extensions_utils.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/message_channel.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/pepper/v8_var_converter.cc View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
M extensions/renderer/binding_generating_native_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/renderer/blob_native_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/document_custom_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/event_bindings.cc View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
M extensions/renderer/file_system_natives.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M extensions/renderer/i18n_custom_bindings.cc View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M extensions/renderer/module_system.cc View 1 2 6 chunks +7 lines, -9 lines 0 comments Download
M extensions/renderer/print_native_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/runtime_custom_bindings.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M extensions/renderer/safe_builtins.cc View 1 2 3 chunks +7 lines, -6 lines 0 comments Download
M extensions/renderer/set_icon_natives.cc View 1 2 4 chunks +6 lines, -4 lines 0 comments Download
M extensions/renderer/v8_context_native_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/js/core.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M net/proxy/proxy_resolver_v8.cc View 1 2 5 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jochen (gone - plz use gerrit)
lgtm I'd recommend eroman@ for net/ kalman@ for extensions/ and jamesr@ for mojo/
6 years, 1 month ago (2014-11-20 15:35:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/744723002/40001
6 years, 1 month ago (2014-11-20 15:38:27 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-20 17:55:24 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 17:55:55 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/a261b771b94ccf7bb63f932b0adc8b7f2dc2e946
Cr-Commit-Position: refs/heads/master@{#305034}

Powered by Google App Engine
This is Rietveld 408576698