extensions/renderer/v8_context_native_handler.cc - Issue 744723002: remove some calls to to-be-deprecated v8::Value::To* functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/v8_context_native_handler.cc

Issue 744723002: remove some calls to to-be-deprecated v8::Value::To* functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/v8_context_native_handler.cc

diff --git a/extensions/renderer/v8_context_native_handler.cc b/extensions/renderer/v8_context_native_handler.cc

index 09f9c8aebaebcc507c946eaa354dbd606a58ce11..0fd538d9ec932be6bf68b3b5f75840538192e2c1 100644

--- a/extensions/renderer/v8_context_native_handler.cc

+++ b/extensions/renderer/v8_context_native_handler.cc

@@ -32,7 +32,7 @@ void V8ContextNativeHandler::GetAvailability(

const v8::FunctionCallbackInfo<v8::Value>& args) {

CHECK_EQ(args.Length(), 1);

v8::Isolate* isolate = args.GetIsolate();

- std::string api_name = *v8::String::Utf8Value(args[0]->ToString());

+ std::string api_name = *v8::String::Utf8Value(args[0]);

Feature::Availability availability = context_->GetAvailability(api_name);

v8::Handle<v8::Object> ret = v8::Object::New(isolate);

« no previous file with comments | « extensions/renderer/set_icon_natives.cc ('k') | mojo/edk/js/core.cc » ('j') | no next file with comments »