extensions/renderer/blob_native_handler.cc - Issue 744723002: remove some calls to to-be-deprecated v8::Value::To* functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/blob_native_handler.cc

Issue 744723002: remove some calls to to-be-deprecated v8::Value::To* functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/blob_native_handler.cc

diff --git a/extensions/renderer/blob_native_handler.cc b/extensions/renderer/blob_native_handler.cc

index be38cec6fc020bb1138821dd1d68ef0d69eee641..b8b2e5189091fa230e95834c0583e4011f2c32ea 100644

--- a/extensions/renderer/blob_native_handler.cc

+++ b/extensions/renderer/blob_native_handler.cc

@@ -28,8 +28,8 @@ void TakeBrowserProcessBlob(const v8::FunctionCallbackInfo<v8::Value>& args) {

DCHECK(args[0]->IsString());

DCHECK(args[1]->IsString());

DCHECK(args[2]->IsInt32());

- std::string uuid(*v8::String::Utf8Value(args[0]->ToString()));

- std::string type(*v8::String::Utf8Value(args[1]->ToString()));

+ std::string uuid(*v8::String::Utf8Value(args[0]));

+ std::string type(*v8::String::Utf8Value(args[1]));

blink::WebBlob blob =

blink::WebBlob::createFromUUID(blink::WebString::fromUTF8(uuid),

blink::WebString::fromUTF8(type),

« no previous file with comments | « extensions/renderer/binding_generating_native_handler.cc ('k') | extensions/renderer/document_custom_bindings.cc » ('j') | no next file with comments »