Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: extensions/renderer/file_system_natives.cc

Issue 744723002: remove some calls to to-be-deprecated v8::Value::To* functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/event_bindings.cc ('k') | extensions/renderer/i18n_custom_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/file_system_natives.cc
diff --git a/extensions/renderer/file_system_natives.cc b/extensions/renderer/file_system_natives.cc
index 6604c39cea72df1419f323521486af0b497d1445..a06eec8cdd35de2a7cc30b80f18a75e2c3f93b3a 100644
--- a/extensions/renderer/file_system_natives.cc
+++ b/extensions/renderer/file_system_natives.cc
@@ -72,7 +72,7 @@ void FileSystemNatives::GetFileEntry(
const v8::FunctionCallbackInfo<v8::Value>& args) {
DCHECK(args.Length() == 5);
DCHECK(args[0]->IsString());
- std::string type_string = *v8::String::Utf8Value(args[0]->ToString());
+ std::string type_string = *v8::String::Utf8Value(args[0]);
blink::WebFileSystemType type;
bool is_valid_type = storage::GetFileSystemPublicType(type_string, &type);
DCHECK(is_valid_type);
@@ -83,9 +83,9 @@ void FileSystemNatives::GetFileEntry(
DCHECK(args[1]->IsString());
DCHECK(args[2]->IsString());
DCHECK(args[3]->IsString());
- std::string file_system_name(*v8::String::Utf8Value(args[1]->ToString()));
- GURL file_system_root_url(*v8::String::Utf8Value(args[2]->ToString()));
- std::string file_path_string(*v8::String::Utf8Value(args[3]->ToString()));
+ std::string file_system_name(*v8::String::Utf8Value(args[1]));
+ GURL file_system_root_url(*v8::String::Utf8Value(args[2]));
+ std::string file_path_string(*v8::String::Utf8Value(args[3]));
base::FilePath file_path = base::FilePath::FromUTF8Unsafe(file_path_string);
DCHECK(storage::VirtualPath::IsAbsolute(file_path.value()));
@@ -113,7 +113,7 @@ void FileSystemNatives::CrackIsolatedFileSystemName(
const v8::FunctionCallbackInfo<v8::Value>& args) {
DCHECK_EQ(args.Length(), 1);
DCHECK(args[0]->IsString());
- std::string filesystem_name = *v8::String::Utf8Value(args[0]->ToString());
+ std::string filesystem_name = *v8::String::Utf8Value(args[0]);
std::string filesystem_id;
if (!storage::CrackIsolatedFileSystemName(filesystem_name, &filesystem_id))
return;
« no previous file with comments | « extensions/renderer/event_bindings.cc ('k') | extensions/renderer/i18n_custom_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698