Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Side by Side Diff: extensions/renderer/file_system_natives.cc

Issue 744723002: remove some calls to to-be-deprecated v8::Value::To* functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/renderer/event_bindings.cc ('k') | extensions/renderer/i18n_custom_bindings.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/renderer/file_system_natives.h" 5 #include "extensions/renderer/file_system_natives.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "extensions/common/constants.h" 9 #include "extensions/common/constants.h"
10 #include "extensions/renderer/script_context.h" 10 #include "extensions/renderer/script_context.h"
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 blink::WebFileSystemTypeIsolated, 65 blink::WebFileSystemTypeIsolated,
66 blink::WebString::fromUTF8(name), 66 blink::WebString::fromUTF8(name),
67 root_url) 67 root_url)
68 .toV8Value(args.Holder(), args.GetIsolate())); 68 .toV8Value(args.Holder(), args.GetIsolate()));
69 } 69 }
70 70
71 void FileSystemNatives::GetFileEntry( 71 void FileSystemNatives::GetFileEntry(
72 const v8::FunctionCallbackInfo<v8::Value>& args) { 72 const v8::FunctionCallbackInfo<v8::Value>& args) {
73 DCHECK(args.Length() == 5); 73 DCHECK(args.Length() == 5);
74 DCHECK(args[0]->IsString()); 74 DCHECK(args[0]->IsString());
75 std::string type_string = *v8::String::Utf8Value(args[0]->ToString()); 75 std::string type_string = *v8::String::Utf8Value(args[0]);
76 blink::WebFileSystemType type; 76 blink::WebFileSystemType type;
77 bool is_valid_type = storage::GetFileSystemPublicType(type_string, &type); 77 bool is_valid_type = storage::GetFileSystemPublicType(type_string, &type);
78 DCHECK(is_valid_type); 78 DCHECK(is_valid_type);
79 if (is_valid_type == false) { 79 if (is_valid_type == false) {
80 return; 80 return;
81 } 81 }
82 82
83 DCHECK(args[1]->IsString()); 83 DCHECK(args[1]->IsString());
84 DCHECK(args[2]->IsString()); 84 DCHECK(args[2]->IsString());
85 DCHECK(args[3]->IsString()); 85 DCHECK(args[3]->IsString());
86 std::string file_system_name(*v8::String::Utf8Value(args[1]->ToString())); 86 std::string file_system_name(*v8::String::Utf8Value(args[1]));
87 GURL file_system_root_url(*v8::String::Utf8Value(args[2]->ToString())); 87 GURL file_system_root_url(*v8::String::Utf8Value(args[2]));
88 std::string file_path_string(*v8::String::Utf8Value(args[3]->ToString())); 88 std::string file_path_string(*v8::String::Utf8Value(args[3]));
89 base::FilePath file_path = base::FilePath::FromUTF8Unsafe(file_path_string); 89 base::FilePath file_path = base::FilePath::FromUTF8Unsafe(file_path_string);
90 DCHECK(storage::VirtualPath::IsAbsolute(file_path.value())); 90 DCHECK(storage::VirtualPath::IsAbsolute(file_path.value()));
91 91
92 DCHECK(args[4]->IsBoolean()); 92 DCHECK(args[4]->IsBoolean());
93 blink::WebDOMFileSystem::EntryType entry_type = 93 blink::WebDOMFileSystem::EntryType entry_type =
94 args[4]->BooleanValue() ? blink::WebDOMFileSystem::EntryTypeDirectory 94 args[4]->BooleanValue() ? blink::WebDOMFileSystem::EntryTypeDirectory
95 : blink::WebDOMFileSystem::EntryTypeFile; 95 : blink::WebDOMFileSystem::EntryTypeFile;
96 96
97 blink::WebLocalFrame* webframe = 97 blink::WebLocalFrame* webframe =
98 blink::WebLocalFrame::frameForContext(context()->v8_context()); 98 blink::WebLocalFrame::frameForContext(context()->v8_context());
99 DCHECK(webframe); 99 DCHECK(webframe);
100 args.GetReturnValue().Set( 100 args.GetReturnValue().Set(
101 blink::WebDOMFileSystem::create( 101 blink::WebDOMFileSystem::create(
102 webframe, 102 webframe,
103 type, 103 type,
104 blink::WebString::fromUTF8(file_system_name), 104 blink::WebString::fromUTF8(file_system_name),
105 file_system_root_url) 105 file_system_root_url)
106 .createV8Entry(blink::WebString::fromUTF8(file_path_string), 106 .createV8Entry(blink::WebString::fromUTF8(file_path_string),
107 entry_type, 107 entry_type,
108 args.Holder(), 108 args.Holder(),
109 args.GetIsolate())); 109 args.GetIsolate()));
110 } 110 }
111 111
112 void FileSystemNatives::CrackIsolatedFileSystemName( 112 void FileSystemNatives::CrackIsolatedFileSystemName(
113 const v8::FunctionCallbackInfo<v8::Value>& args) { 113 const v8::FunctionCallbackInfo<v8::Value>& args) {
114 DCHECK_EQ(args.Length(), 1); 114 DCHECK_EQ(args.Length(), 1);
115 DCHECK(args[0]->IsString()); 115 DCHECK(args[0]->IsString());
116 std::string filesystem_name = *v8::String::Utf8Value(args[0]->ToString()); 116 std::string filesystem_name = *v8::String::Utf8Value(args[0]);
117 std::string filesystem_id; 117 std::string filesystem_id;
118 if (!storage::CrackIsolatedFileSystemName(filesystem_name, &filesystem_id)) 118 if (!storage::CrackIsolatedFileSystemName(filesystem_name, &filesystem_id))
119 return; 119 return;
120 120
121 args.GetReturnValue().Set(v8::String::NewFromUtf8(args.GetIsolate(), 121 args.GetReturnValue().Set(v8::String::NewFromUtf8(args.GetIsolate(),
122 filesystem_id.c_str(), 122 filesystem_id.c_str(),
123 v8::String::kNormalString, 123 v8::String::kNormalString,
124 filesystem_id.size())); 124 filesystem_id.size()));
125 } 125 }
126 126
(...skipping 20 matching lines...) Expand all
147 std::string message(*v8::String::Utf8Value(args[1])); 147 std::string message(*v8::String::Utf8Value(args[1]));
148 // message is optional hence empty is fine. 148 // message is optional hence empty is fine.
149 149
150 blink::WebDOMError dom_error = blink::WebDOMError::create( 150 blink::WebDOMError dom_error = blink::WebDOMError::create(
151 blink::WebString::fromUTF8(name), blink::WebString::fromUTF8(message)); 151 blink::WebString::fromUTF8(name), blink::WebString::fromUTF8(message));
152 args.GetReturnValue().Set( 152 args.GetReturnValue().Set(
153 dom_error.toV8Value(args.Holder(), args.GetIsolate())); 153 dom_error.toV8Value(args.Holder(), args.GetIsolate()));
154 } 154 }
155 155
156 } // namespace extensions 156 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/renderer/event_bindings.cc ('k') | extensions/renderer/i18n_custom_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698