Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: extensions/renderer/binding_generating_native_handler.cc

Issue 744723002: remove some calls to to-be-deprecated v8::Value::To* functions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/pepper/v8_var_converter.cc ('k') | extensions/renderer/blob_native_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/binding_generating_native_handler.cc
diff --git a/extensions/renderer/binding_generating_native_handler.cc b/extensions/renderer/binding_generating_native_handler.cc
index f83f1e532c74ee6f30159e1987a3d0a3308161d1..b502d1d5ac5a33aaf6ed86b883288da4baf4183a 100644
--- a/extensions/renderer/binding_generating_native_handler.cc
+++ b/extensions/renderer/binding_generating_native_handler.cc
@@ -18,17 +18,17 @@ v8::Handle<v8::Object> BindingGeneratingNativeHandler::NewInstance() {
v8::Isolate* isolate = module_system_->GetIsolate();
v8::EscapableHandleScope scope(isolate);
v8::Handle<v8::Object> binding_module =
- module_system_->Require("binding")->ToObject();
+ module_system_->Require("binding")->ToObject(isolate);
v8::Handle<v8::Object> binding =
binding_module->Get(v8::String::NewFromUtf8(isolate, "Binding"))
- ->ToObject();
+ ->ToObject(isolate);
v8::Handle<v8::Function> create_binding =
binding->Get(v8::String::NewFromUtf8(isolate, "create"))
.As<v8::Function>();
v8::Handle<v8::Value> argv[] = {
v8::String::NewFromUtf8(isolate, api_name_.c_str())};
v8::Handle<v8::Object> binding_instance =
- create_binding->Call(binding, arraysize(argv), argv)->ToObject();
+ create_binding->Call(binding, arraysize(argv), argv)->ToObject(isolate);
v8::Handle<v8::Function> generate =
binding_instance->Get(v8::String::NewFromUtf8(isolate, "generate"))
.As<v8::Function>();
« no previous file with comments | « content/renderer/pepper/v8_var_converter.cc ('k') | extensions/renderer/blob_native_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698