Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 733253004: PropertyDetails cleanup: NORMAL property type merged with FIELD. (Closed)

Created:
6 years, 1 month ago by Igor Sheludko
Modified:
6 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

PropertyDetails cleanup: NORMAL property type merged with FIELD. First step towards replacing PropertyType with two enums: {DATA,ACCESSOR} x {CONST,WRITABLE}. Committed: https://chromium.googlesource.com/v8/v8/+/0288db0e91d1a88623cbe81681fe2d2e535a93a6

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -106 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/handler-compiler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/lookup.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/lookup.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/lookup-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/mirror-debugger.js View 3 chunks +5 lines, -9 lines 0 comments Download
M src/objects.cc View 1 15 chunks +15 lines, -29 lines 0 comments Download
M src/objects-printer.cc View 3 chunks +1 line, -7 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/property.h View 4 chunks +2 lines, -5 lines 0 comments Download
M src/property.cc View 2 chunks +43 lines, -5 lines 0 comments Download
M src/property-details.h View 4 chunks +12 lines, -15 lines 0 comments Download
M src/runtime/runtime.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-debug.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/mirror-object.js View 1 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Igor Sheludko
PTAL
6 years, 1 month ago (2014-11-19 09:26:33 UTC) #2
Toon Verwaest
LGTM, but I'd replace FIELD by DATA, so soon we can get rid of the ...
6 years, 1 month ago (2014-11-19 10:38:53 UTC) #3
Igor Sheludko
On 2014/11/19 10:38:53, Toon Verwaest wrote: > LGTM, but I'd replace FIELD by DATA, so ...
6 years, 1 month ago (2014-11-19 11:16:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733253004/20001
6 years, 1 month ago (2014-11-19 11:18:23 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-19 11:45:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698