src/heap-snapshot-generator.cc - Issue 733253004: PropertyDetails cleanup: NORMAL property type merged with FIELD.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap-snapshot-generator.cc

Issue 733253004: PropertyDetails cleanup: NORMAL property type merged with FIELD. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: cleanup Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap-snapshot-generator.cc

diff --git a/src/heap-snapshot-generator.cc b/src/heap-snapshot-generator.cc

index 1406ed57f673b2ab8482a5c8cd0b4548f57314a6..b7b290e363b52b123a405786c50e4fa028b96b1d 100644

--- a/src/heap-snapshot-generator.cc

+++ b/src/heap-snapshot-generator.cc

@@ -1671,9 +1671,6 @@ void V8HeapExplorer::ExtractPropertyReferences(JSObject* js_obj, int entry) {

js_obj, entry,

descs->GetKey(i), descs->GetValue(i));

break;

- case NORMAL: // only in slow mode

- UNREACHABLE();

- break;

}

} else {

« no previous file with comments | « src/bootstrapper.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »