Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Side by Side Diff: src/mips64/macro-assembler-mips64.cc

Issue 733253004: PropertyDetails cleanup: NORMAL property type merged with FIELD. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cleanup Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/macro-assembler-mips.cc ('k') | src/mirror-debugger.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <limits.h> // For LONG_MIN, LONG_MAX. 5 #include <limits.h> // For LONG_MIN, LONG_MAX.
6 6
7 #include "src/v8.h" 7 #include "src/v8.h"
8 8
9 #if V8_TARGET_ARCH_MIPS64 9 #if V8_TARGET_ARCH_MIPS64
10 10
(...skipping 577 matching lines...) Expand 10 before | Expand all | Expand 10 after
588 588
589 ld(at, FieldMemOperand(reg2, SeededNumberDictionary::kElementsStartOffset)); 589 ld(at, FieldMemOperand(reg2, SeededNumberDictionary::kElementsStartOffset));
590 if (i != kNumberDictionaryProbes - 1) { 590 if (i != kNumberDictionaryProbes - 1) {
591 Branch(&done, eq, key, Operand(at)); 591 Branch(&done, eq, key, Operand(at));
592 } else { 592 } else {
593 Branch(miss, ne, key, Operand(at)); 593 Branch(miss, ne, key, Operand(at));
594 } 594 }
595 } 595 }
596 596
597 bind(&done); 597 bind(&done);
598 // Check that the value is a normal property. 598 // Check that the value is a field property.
599 // reg2: elements + (index * kPointerSize). 599 // reg2: elements + (index * kPointerSize).
600 const int kDetailsOffset = 600 const int kDetailsOffset =
601 SeededNumberDictionary::kElementsStartOffset + 2 * kPointerSize; 601 SeededNumberDictionary::kElementsStartOffset + 2 * kPointerSize;
602 ld(reg1, FieldMemOperand(reg2, kDetailsOffset)); 602 ld(reg1, FieldMemOperand(reg2, kDetailsOffset));
603 DCHECK_EQ(FIELD, 0);
603 And(at, reg1, Operand(Smi::FromInt(PropertyDetails::TypeField::kMask))); 604 And(at, reg1, Operand(Smi::FromInt(PropertyDetails::TypeField::kMask)));
604 Branch(miss, ne, at, Operand(zero_reg)); 605 Branch(miss, ne, at, Operand(zero_reg));
605 606
606 // Get the value at the masked, scaled index and return. 607 // Get the value at the masked, scaled index and return.
607 const int kValueOffset = 608 const int kValueOffset =
608 SeededNumberDictionary::kElementsStartOffset + kPointerSize; 609 SeededNumberDictionary::kElementsStartOffset + kPointerSize;
609 ld(result, FieldMemOperand(reg2, kValueOffset)); 610 ld(result, FieldMemOperand(reg2, kValueOffset));
610 } 611 }
611 612
612 613
(...skipping 5474 matching lines...) Expand 10 before | Expand all | Expand 10 after
6087 } 6088 }
6088 if (mag.shift > 0) sra(result, result, mag.shift); 6089 if (mag.shift > 0) sra(result, result, mag.shift);
6089 srl(at, dividend, 31); 6090 srl(at, dividend, 31);
6090 Addu(result, result, Operand(at)); 6091 Addu(result, result, Operand(at));
6091 } 6092 }
6092 6093
6093 6094
6094 } } // namespace v8::internal 6095 } } // namespace v8::internal
6095 6096
6096 #endif // V8_TARGET_ARCH_MIPS64 6097 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/mips/macro-assembler-mips.cc ('k') | src/mirror-debugger.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698