Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Unified Diff: src/objects-printer.cc

Issue 733253004: PropertyDetails cleanup: NORMAL property type merged with FIELD. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cleanup Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | src/ppc/macro-assembler-ppc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-printer.cc
diff --git a/src/objects-printer.cc b/src/objects-printer.cc
index dff4dd232957c5e6e49bd4abeb37687be3e0d1b7..db3d041c18d536a700ee5eced5921975c2a16d41 100644
--- a/src/objects-printer.cc
+++ b/src/objects-printer.cc
@@ -247,9 +247,6 @@ void JSObject::PrintProperties(std::ostream& os) { // NOLINT
case CALLBACKS:
os << Brief(descs->GetCallbacksObject(i)) << " (callback)\n";
break;
- case NORMAL: // only in slow mode
- UNREACHABLE();
- break;
}
}
} else {
@@ -1073,6 +1070,7 @@ void DescriptorArray::Print() {
void DescriptorArray::PrintDescriptors(std::ostream& os) { // NOLINT
+ HandleScope scope(GetIsolate());
os << "Descriptor array " << number_of_descriptors() << "\n";
for (int i = 0; i < number_of_descriptors(); i++) {
Descriptor desc;
@@ -1157,10 +1155,6 @@ void TransitionArray::PrintTransitions(std::ostream& os,
case CALLBACKS:
os << " (transition to callback " << Brief(GetTargetValue(i)) << ")";
break;
- // Values below are never in the target descriptor array.
- case NORMAL:
- UNREACHABLE();
- break;
}
os << ", attrs: " << details.attributes();
}
« no previous file with comments | « src/objects.cc ('k') | src/ppc/macro-assembler-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698