Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/ppc/macro-assembler-ppc.cc

Issue 733253004: PropertyDetails cleanup: NORMAL property type merged with FIELD. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cleanup Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects-printer.cc ('k') | src/property.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <assert.h> // For assert 5 #include <assert.h> // For assert
6 #include <limits.h> // For LONG_MIN, LONG_MAX. 6 #include <limits.h> // For LONG_MIN, LONG_MAX.
7 7
8 #include "src/v8.h" 8 #include "src/v8.h"
9 9
10 #if V8_TARGET_ARCH_PPC 10 #if V8_TARGET_ARCH_PPC
(...skipping 1491 matching lines...) Expand 10 before | Expand all | Expand 10 after
1502 FieldMemOperand(t2, SeededNumberDictionary::kElementsStartOffset)); 1502 FieldMemOperand(t2, SeededNumberDictionary::kElementsStartOffset));
1503 cmp(key, ip); 1503 cmp(key, ip);
1504 if (i != kNumberDictionaryProbes - 1) { 1504 if (i != kNumberDictionaryProbes - 1) {
1505 beq(&done); 1505 beq(&done);
1506 } else { 1506 } else {
1507 bne(miss); 1507 bne(miss);
1508 } 1508 }
1509 } 1509 }
1510 1510
1511 bind(&done); 1511 bind(&done);
1512 // Check that the value is a normal property. 1512 // Check that the value is a field property.
1513 // t2: elements + (index * kPointerSize) 1513 // t2: elements + (index * kPointerSize)
1514 const int kDetailsOffset = 1514 const int kDetailsOffset =
1515 SeededNumberDictionary::kElementsStartOffset + 2 * kPointerSize; 1515 SeededNumberDictionary::kElementsStartOffset + 2 * kPointerSize;
1516 LoadP(t1, FieldMemOperand(t2, kDetailsOffset)); 1516 LoadP(t1, FieldMemOperand(t2, kDetailsOffset));
1517 LoadSmiLiteral(ip, Smi::FromInt(PropertyDetails::TypeField::kMask)); 1517 LoadSmiLiteral(ip, Smi::FromInt(PropertyDetails::TypeField::kMask));
1518 DCHECK_EQ(FIELD, 0);
1518 and_(r0, t1, ip, SetRC); 1519 and_(r0, t1, ip, SetRC);
1519 bne(miss, cr0); 1520 bne(miss, cr0);
1520 1521
1521 // Get the value at the masked, scaled index and return. 1522 // Get the value at the masked, scaled index and return.
1522 const int kValueOffset = 1523 const int kValueOffset =
1523 SeededNumberDictionary::kElementsStartOffset + kPointerSize; 1524 SeededNumberDictionary::kElementsStartOffset + kPointerSize;
1524 LoadP(result, FieldMemOperand(t2, kValueOffset)); 1525 LoadP(result, FieldMemOperand(t2, kValueOffset));
1525 } 1526 }
1526 1527
1527 1528
(...skipping 3281 matching lines...) Expand 10 before | Expand all | Expand 10 after
4809 } 4810 }
4810 if (mag.shift > 0) srawi(result, result, mag.shift); 4811 if (mag.shift > 0) srawi(result, result, mag.shift);
4811 ExtractBit(r0, dividend, 31); 4812 ExtractBit(r0, dividend, 31);
4812 add(result, result, r0); 4813 add(result, result, r0);
4813 } 4814 }
4814 4815
4815 } // namespace internal 4816 } // namespace internal
4816 } // namespace v8 4817 } // namespace v8
4817 4818
4818 #endif // V8_TARGET_ARCH_PPC 4819 #endif // V8_TARGET_ARCH_PPC
OLDNEW
« no previous file with comments | « src/objects-printer.cc ('k') | src/property.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698