Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/heap-snapshot-generator.cc

Issue 733253004: PropertyDetails cleanup: NORMAL property type merged with FIELD. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cleanup Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/bootstrapper.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/heap-snapshot-generator-inl.h" 7 #include "src/heap-snapshot-generator-inl.h"
8 8
9 #include "src/allocation-tracker.h" 9 #include "src/allocation-tracker.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1653 matching lines...) Expand 10 before | Expand all | Expand 10 after
1664 case CONSTANT: 1664 case CONSTANT:
1665 SetPropertyReference( 1665 SetPropertyReference(
1666 js_obj, entry, 1666 js_obj, entry,
1667 descs->GetKey(i), descs->GetConstant(i)); 1667 descs->GetKey(i), descs->GetConstant(i));
1668 break; 1668 break;
1669 case CALLBACKS: 1669 case CALLBACKS:
1670 ExtractAccessorPairProperty( 1670 ExtractAccessorPairProperty(
1671 js_obj, entry, 1671 js_obj, entry,
1672 descs->GetKey(i), descs->GetValue(i)); 1672 descs->GetKey(i), descs->GetValue(i));
1673 break; 1673 break;
1674 case NORMAL: // only in slow mode
1675 UNREACHABLE();
1676 break;
1677 } 1674 }
1678 } 1675 }
1679 } else { 1676 } else {
1680 NameDictionary* dictionary = js_obj->property_dictionary(); 1677 NameDictionary* dictionary = js_obj->property_dictionary();
1681 int length = dictionary->Capacity(); 1678 int length = dictionary->Capacity();
1682 for (int i = 0; i < length; ++i) { 1679 for (int i = 0; i < length; ++i) {
1683 Object* k = dictionary->KeyAt(i); 1680 Object* k = dictionary->KeyAt(i);
1684 if (dictionary->IsKey(k)) { 1681 if (dictionary->IsKey(k)) {
1685 Object* target = dictionary->ValueAt(i); 1682 Object* target = dictionary->ValueAt(i);
1686 // We assume that global objects can only have slow properties. 1683 // We assume that global objects can only have slow properties.
(...skipping 1450 matching lines...) Expand 10 before | Expand all | Expand 10 after
3137 writer_->AddString("\"<dummy>\""); 3134 writer_->AddString("\"<dummy>\"");
3138 for (int i = 1; i < sorted_strings.length(); ++i) { 3135 for (int i = 1; i < sorted_strings.length(); ++i) {
3139 writer_->AddCharacter(','); 3136 writer_->AddCharacter(',');
3140 SerializeString(sorted_strings[i]); 3137 SerializeString(sorted_strings[i]);
3141 if (writer_->aborted()) return; 3138 if (writer_->aborted()) return;
3142 } 3139 }
3143 } 3140 }
3144 3141
3145 3142
3146 } } // namespace v8::internal 3143 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/bootstrapper.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698