Enable unused param checking for public includes.

Enable unused param checking for public includes.

This CL cleans up the existing violations and enables the
build time check to ensure that we don't regress.

The motiviation behind this change is to allow clients who include
our headers to be able to build with this warning enabled.

Committed: https://skia.googlesource.com/skia/+/c87dd2ce965cd1bbc8a74abe0c141658a469d7f2

[djsollen, 2014-11-14 15:27:43]

djsollen@google.com changed reviewers:
+ reed@google.com

[djsollen, 2014-11-14 16:19:21]

djsollen@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2014-11-14 16:30:15]

https://codereview.chromium.org/726923002/diff/20001/include/core/SkTArray.h
File include/core/SkTArray.h (left):

https://codereview.chromium.org/726923002/diff/20001/include/core/SkTArray.h#...
include/core/SkTArray.h:471: SkASSERT(atIndex == array->count());
This seems like a loss.  Seems better to SkDEBUGCODE(atIndex).

https://codereview.chromium.org/726923002/diff/20001/include/gpu/GrColor.h
File include/gpu/GrColor.h (right):

https://codereview.chromium.org/726923002/diff/20001/include/gpu/GrColor.h#ne...
include/gpu/GrColor.h:69: static inline void GrColorIsPMAssert(GrColor
SK_UNUSED(c)) {
--> SkDEBUGCODE?  Makes it a little clearer when it's used.  I wouldn't be
surprised if it triggered another warning if we use an argument marked unused.

https://codereview.chromium.org/726923002/diff/20001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/726923002/diff/20001/include/gpu/GrContext.h#...
include/gpu/GrContext.h:830: AutoClip(GrContext* context, InitialClip
SK_UNUSED(initialState))
SkDEBUGCODE

https://codereview.chromium.org/726923002/diff/20001/include/ports/SkFontMgr.h
File include/ports/SkFontMgr.h (right):

https://codereview.chromium.org/726923002/diff/20001/include/ports/SkFontMgr....
include/ports/SkFontMgr.h:126: SkUnichar character) const = 0;
This seems like something you might want to spin off into another review.  It's
not really clear to me it's better after the change.

[djsollen, 2014-11-14 18:55:23]

https://codereview.chromium.org/726923002/diff/20001/include/core/SkTArray.h
File include/core/SkTArray.h (left):

https://codereview.chromium.org/726923002/diff/20001/include/core/SkTArray.h#...
include/core/SkTArray.h:471: SkASSERT(atIndex == array->count());
On 2014/11/14 16:30:15, mtklein wrote:
> This seems like a loss.  Seems better to SkDEBUGCODE(atIndex).

Done.

https://codereview.chromium.org/726923002/diff/20001/include/gpu/GrColor.h
File include/gpu/GrColor.h (right):

https://codereview.chromium.org/726923002/diff/20001/include/gpu/GrColor.h#ne...
include/gpu/GrColor.h:69: static inline void GrColorIsPMAssert(GrColor
SK_UNUSED(c)) {
On 2014/11/14 16:30:15, mtklein wrote:
> --> SkDEBUGCODE?  Makes it a little clearer when it's used.  I wouldn't be
> surprised if it triggered another warning if we use an argument marked unused.

Done.

https://codereview.chromium.org/726923002/diff/20001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/726923002/diff/20001/include/gpu/GrContext.h#...
include/gpu/GrContext.h:830: AutoClip(GrContext* context, InitialClip
SK_UNUSED(initialState))
On 2014/11/14 16:30:15, mtklein wrote:
> SkDEBUGCODE

Done.

https://codereview.chromium.org/726923002/diff/20001/include/ports/SkFontMgr.h
File include/ports/SkFontMgr.h (right):

https://codereview.chromium.org/726923002/diff/20001/include/ports/SkFontMgr....
include/ports/SkFontMgr.h:126: SkUnichar character) const = 0;
On 2014/11/14 16:30:15, mtklein wrote:
> This seems like something you might want to spin off into another review. 
It's
> not really clear to me it's better after the change.

https://codereview.chromium.org/728873002/

[mtklein, 2014-11-14 18:57:22]

lgtm

[djsollen, 2014-11-14 19:01:52]

The CQ bit was checked by djsollen@google.com

[commit-bot: I haz the power, 2014-11-14 19:02:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/726923002/40001

[commit-bot: I haz the power, 2014-11-14 19:11:50]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/c87dd2ce965cd1bbc8a74abe0c141658a469d7f2