Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gyp/tools.gyp

Issue 726923002: Enable unused param checking for public includes. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/core/SkCanvas.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/tools.gyp
diff --git a/gyp/tools.gyp b/gyp/tools.gyp
index 30e3e9ea0d8b3d15d989eddb40ee457ab5e24ceb..23790a6a3fe927dd4c1e4106925b7720a051a63b 100644
--- a/gyp/tools.gyp
+++ b/gyp/tools.gyp
@@ -628,7 +628,9 @@
{
'target_name': 'test_public_includes',
'type': 'static_library',
- #'cflags!': [ '-Wno-unused-parameter' ],
+ # Ensure that our public headers don't have unused params so that clients
+ # (e.g. Android) that include us can build with these warnings enabled
+ 'cflags!': [ '-Wno-unused-parameter' ],
'variables': {
'includes_to_test': [
'<(skia_include_path)/animator',
« no previous file with comments | « no previous file | include/core/SkCanvas.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698