Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1066)

Side by Side Diff: gyp/tools.gyp

Issue 726923002: Enable unused param checking for public includes. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | include/core/SkCanvas.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # GYP file to build various tools. 1 # GYP file to build various tools.
2 # 2 #
3 # To build on Linux: 3 # To build on Linux:
4 # ./gyp_skia tools.gyp && make tools 4 # ./gyp_skia tools.gyp && make tools
5 # 5 #
6 { 6 {
7 'includes': [ 7 'includes': [
8 'apptype_console.gypi', 8 'apptype_console.gypi',
9 ], 9 ],
10 'targets': [ 10 'targets': [
(...skipping 610 matching lines...) Expand 10 before | Expand all | Expand 10 after
621 '../tools/ProcStats.h', 621 '../tools/ProcStats.h',
622 '../tools/ProcStats.cpp', 622 '../tools/ProcStats.cpp',
623 ], 623 ],
624 'direct_dependent_settings': { 624 'direct_dependent_settings': {
625 'include_dirs': [ '../tools', ], 625 'include_dirs': [ '../tools', ],
626 }, 626 },
627 }, 627 },
628 { 628 {
629 'target_name': 'test_public_includes', 629 'target_name': 'test_public_includes',
630 'type': 'static_library', 630 'type': 'static_library',
631 #'cflags!': [ '-Wno-unused-parameter' ], 631 # Ensure that our public headers don't have unused params so that clients
632 # (e.g. Android) that include us can build with these warnings enabled
633 'cflags!': [ '-Wno-unused-parameter' ],
632 'variables': { 634 'variables': {
633 'includes_to_test': [ 635 'includes_to_test': [
634 '<(skia_include_path)/animator', 636 '<(skia_include_path)/animator',
635 '<(skia_include_path)/c', 637 '<(skia_include_path)/c',
636 '<(skia_include_path)/config', 638 '<(skia_include_path)/config',
637 '<(skia_include_path)/core', 639 '<(skia_include_path)/core',
638 '<(skia_include_path)/effects', 640 '<(skia_include_path)/effects',
639 '<(skia_include_path)/gpu', 641 '<(skia_include_path)/gpu',
640 '<(skia_include_path)/images', 642 '<(skia_include_path)/images',
641 '<(skia_include_path)/pathops', 643 '<(skia_include_path)/pathops',
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
777 'flags.gyp:flags', 779 'flags.gyp:flags',
778 'skia_lib.gyp:skia_lib', 780 'skia_lib.gyp:skia_lib',
779 'resources', 781 'resources',
780 ], 782 ],
781 }, 783 },
782 ], 784 ],
783 }, 785 },
784 ], 786 ],
785 ], 787 ],
786 } 788 }
OLDNEW
« no previous file with comments | « no previous file | include/core/SkCanvas.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698