Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Issue 723973002: Adding support for opening URL in new tab from inline Content (Closed)

Created:
6 years, 1 month ago by AKVT
Modified:
6 years, 1 month ago
Reviewers:
Bernhard Bauer, aruslan
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding support for opening URL in new tab from Content Currently after enabling Tab manager in Chrome, links which supposed to be opened on new tab is not working correctly. This change takes care of opening the link in new tab whenever applicable. Committed: https://crrev.com/336159cf3f6740237f304e01bb6a393f03b8b135 Cr-Commit-Position: refs/heads/master@{#304012}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed the review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
AKVT
@bauerb PTAL this change.
6 years, 1 month ago (2014-11-13 09:10:56 UTC) #2
Bernhard Bauer
https://codereview.chromium.org/723973002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right): https://codereview.chromium.org/723973002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java#newcode254 chrome/android/java/src/org/chromium/chrome/browser/Tab.java:254: } Empty line between methods. https://codereview.chromium.org/723973002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java#newcode258 chrome/android/java/src/org/chromium/chrome/browser/Tab.java:258: for (TabObserver ...
6 years, 1 month ago (2014-11-13 09:38:03 UTC) #3
AKVT
@Bernhard PTAL. https://codereview.chromium.org/723973002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right): https://codereview.chromium.org/723973002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/Tab.java#newcode254 chrome/android/java/src/org/chromium/chrome/browser/Tab.java:254: } On 2014/11/13 09:38:02, Bernhard Bauer wrote: ...
6 years, 1 month ago (2014-11-13 09:48:55 UTC) #4
Bernhard Bauer
lgtm
6 years, 1 month ago (2014-11-13 10:00:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/723973002/20001
6 years, 1 month ago (2014-11-13 10:01:49 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-13 10:46:04 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 10:46:52 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/336159cf3f6740237f304e01bb6a393f03b8b135
Cr-Commit-Position: refs/heads/master@{#304012}

Powered by Google App Engine
This is Rietveld 408576698