chrome/android/java/src/org/chromium/chrome/browser/Tab.java - Issue 723973002: Adding support for opening URL in new tab from inline Content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

Issue 723973002: Adding support for opening URL in new tab from inline Content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the review comments. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

index 38abe1ca22d6028b7adc2b072a2ca22826c5ee70..a165baf560b0f346858a101539f51839c62147e4 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

@@ -252,6 +252,15 @@ public class Tab {

public void visibleSSLStateChanged() {

for (TabObserver observer : mObservers) observer.onSSLStateUpdated(Tab.this);

}

+ @Override

+ public void webContentsCreated(long sourceWebContents, long openerRenderFrameId,

+ String frameName, String targetUrl, long newWebContents) {

+ for (TabObserver observer : mObservers) {

+ observer.webContentsCreated(Tab.this, sourceWebContents, openerRenderFrameId,

+ frameName, targetUrl, newWebContents);

+ }

}

private class TabContextMenuPopulator extends ContextMenuPopulatorWrapper {