chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java - Issue 723973002: Adding support for opening URL in new tab from inline Content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java

Issue 723973002: Adding support for opening URL in new tab from inline Content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed the review comments. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/Tab.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java

index 6a65a123612103f105bd423375ce8ac642a78610..47d404b3280bb44cd5eaa0eae882c75d8e46df0e 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java

@@ -75,4 +75,8 @@ public class EmptyTabObserver implements TabObserver {

@Override

public void onDidChangeThemeColor(int color) { }

+ @Override

+ public void webContentsCreated(Tab tab, long sourceWebContents, long openerRenderFrameId,

+ String frameName, String targetUrl, long newWebContents) { }

}