Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeWebContentsDelegateAndroid.java

Issue 723973002: Adding support for opening URL in new tab from inline Content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed the review comments. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser; 5 package org.chromium.chrome.browser;
6 6
7 import android.graphics.Rect; 7 import android.graphics.Rect;
8 import android.graphics.RectF; 8 import android.graphics.RectF;
9 9
10 import org.chromium.base.CalledByNative; 10 import org.chromium.base.CalledByNative;
(...skipping 14 matching lines...) Expand all
25 @CalledByNative 25 @CalledByNative
26 public void onFindMatchRectsAvailable(FindMatchRectsDetails result) { 26 public void onFindMatchRectsAvailable(FindMatchRectsDetails result) {
27 } 27 }
28 28
29 @CalledByNative 29 @CalledByNative
30 public boolean addNewContents(long nativeSourceWebContents, long nativeWebCo ntents, 30 public boolean addNewContents(long nativeSourceWebContents, long nativeWebCo ntents,
31 int disposition, Rect initialPosition, boolean userGesture) { 31 int disposition, Rect initialPosition, boolean userGesture) {
32 return false; 32 return false;
33 } 33 }
34 34
35 @Override
36 public void webContentsCreated(long sourceWebContents, long openerRenderFram eId,
37 String frameName, String targetUrl, long newWebContents) {
38 }
39
35 // Helper functions used to create types that are part of the public interfa ce 40 // Helper functions used to create types that are part of the public interfa ce
36 @CalledByNative 41 @CalledByNative
37 private static Rect createRect(int x, int y, int right, int bottom) { 42 private static Rect createRect(int x, int y, int right, int bottom) {
38 return new Rect(x, y, right, bottom); 43 return new Rect(x, y, right, bottom);
39 } 44 }
40 45
41 @CalledByNative 46 @CalledByNative
42 private static RectF createRectF(float x, float y, float right, float bottom ) { 47 private static RectF createRectF(float x, float y, float right, float bottom ) {
43 return new RectF(x, y, right, bottom); 48 return new RectF(x, y, right, bottom);
44 } 49 }
(...skipping 11 matching lines...) Expand all
56 int version, int numRects, RectF activeRect) { 61 int version, int numRects, RectF activeRect) {
57 return new FindMatchRectsDetails(version, numRects, activeRect); 62 return new FindMatchRectsDetails(version, numRects, activeRect);
58 } 63 }
59 64
60 @CalledByNative 65 @CalledByNative
61 private static void setMatchRectByIndex( 66 private static void setMatchRectByIndex(
62 FindMatchRectsDetails findMatchRectsDetails, int index, RectF rect) { 67 FindMatchRectsDetails findMatchRectsDetails, int index, RectF rect) {
63 findMatchRectsDetails.rects[index] = rect; 68 findMatchRectsDetails.rects[index] = rect;
64 } 69 }
65 } 70 }
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/EmptyTabObserver.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698