Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Side by Side Diff: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java

Issue 723973002: Adding support for opening URL in new tab from inline Content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed the review comments. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.shell; 5 package org.chromium.chrome.shell;
6 6
7 import android.content.Context; 7 import android.content.Context;
8 import android.text.TextUtils; 8 import android.text.TextUtils;
9 9
10 import org.chromium.chrome.browser.Tab; 10 import org.chromium.chrome.browser.Tab;
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
140 @Override 140 @Override
141 public void toggleFullscreenModeForTab(boolean enterFullscreen) { 141 public void toggleFullscreenModeForTab(boolean enterFullscreen) {
142 mIsFullscreen = enterFullscreen; 142 mIsFullscreen = enterFullscreen;
143 super.toggleFullscreenModeForTab(enterFullscreen); 143 super.toggleFullscreenModeForTab(enterFullscreen);
144 } 144 }
145 145
146 @Override 146 @Override
147 public boolean isFullscreenForTabOrPending() { 147 public boolean isFullscreenForTabOrPending() {
148 return mIsFullscreen; 148 return mIsFullscreen;
149 } 149 }
150
151 @Override
152 public void webContentsCreated(long sourceWebContents, long openerRender FrameId,
153 String frameName, String targetUrl, long newWebContents) {
154 mTabManager.createTab(targetUrl, TabLaunchType.FROM_LINK);
155 }
150 } 156 }
151 } 157 }
OLDNEW
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/TabObserver.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698