Adding support for opening URL in new tab from inline Content

chrome/android/java/src/org/chromium/chrome/browser/Tab.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.app.Activity;
 import android.content.Context;
 import android.graphics.Bitmap;
 import android.graphics.Color;
@@ skipping 233 matching lines @@
                 for (TabObserver observer : mObservers) observer.onTitleUpdated(Tab.this);
             }
             if ((flags & INVALIDATE_TYPE_URL) != 0) {
                 for (TabObserver observer : mObservers) observer.onUrlUpdated(Tab.this);
             }
         }
 
         @Override
         public void visibleSSLStateChanged() {
             for (TabObserver observer : mObservers) observer.onSSLStateUpdated(Tab.this);
         }

[Bernhard Bauer, 2014/11/13 09:38:02]

Empty line between methods.

[AKVT, 2014/11/13 09:48:55]

Done.

+        @Override
+        public void webContentsCreated(long sourceWebContents, long openerRenderFrameId,
+                String frameName, String targetUrl, long newWebContents) {
+            for (TabObserver observer : mObservers) observer.webContentsCreated(Tab.this,

[Bernhard Bauer, 2014/11/13 09:38:03]

You can only leave out braces if the whole things fits onto a single line.

[AKVT, 2014/11/13 09:48:54]

Done.

+                    sourceWebContents, openerRenderFrameId, frameName, targetUrl, newWebContents);
+        }
     }
 
     private class TabContextMenuPopulator extends ContextMenuPopulatorWrapper {
         public TabContextMenuPopulator(ContextMenuPopulator populator) {
             super(populator);
         }
 
         @Override
         public void buildContextMenu(ContextMenu menu, Context context, ContextMenuParams params) {
             super.buildContextMenu(menu, context, params);
@@ skipping 955 matching lines @@
     private native void nativeDestroyWebContents(long nativeTabAndroid, boolean deleteNative);
     private native Profile nativeGetProfileAndroid(long nativeTabAndroid);
     private native int nativeLoadUrl(long nativeTabAndroid, String url, String extraHeaders,
             byte[] postData, int transition, String referrerUrl, int referrerPolicy,
             boolean isRendererInitiated);
     private native void nativeSetActiveNavigationEntryTitleForUrl(long nativeTabAndroid, String url,
             String title);
     private native boolean nativePrint(long nativeTabAndroid);
     private native Bitmap nativeGetDefaultFavicon(long nativeTabAndroid);
 }