Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 709133003: Snap optdrawstate in inorder draw buffer and pass into gpu (Closed)

Created:
6 years, 1 month ago by joshua.litt
Modified:
6 years, 1 month ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@remove_friends
Project:
skia
Visibility:
Public.

Description

Snap optdrawstate in inorder draw buffer and pass into gpu BUG=skia: Committed: https://skia.googlesource.com/skia/+/d53a82706ebd227bc0e4dd535118cdd8298131bd

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 3

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -179 lines) Patch
M src/gpu/GrContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrGpu.h View 9 chunks +15 lines, -31 lines 0 comments Download
M src/gpu/GrGpu.cpp View 6 chunks +30 lines, -47 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 1 2 12 chunks +13 lines, -11 lines 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 2 11 chunks +65 lines, -41 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 3 chunks +5 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLPathRendering.cpp View 3 chunks +0 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 2 chunks +6 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 4 chunks +21 lines, -35 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
joshualitt
6 years, 1 month ago (2014-11-07 22:09:59 UTC) #2
bsalomon
https://codereview.chromium.org/709133003/diff/20001/src/gpu/GrInOrderDrawBuffer.h File src/gpu/GrInOrderDrawBuffer.h (right): https://codereview.chromium.org/709133003/diff/20001/src/gpu/GrInOrderDrawBuffer.h#newcode310 src/gpu/GrInOrderDrawBuffer.h:310: SkAutoTUnref<const GrOptDrawState> fCurrentOptDrawState; Looks like this guy doesn't need ...
6 years, 1 month ago (2014-11-10 16:06:15 UTC) #3
joshualitt
https://codereview.chromium.org/709133003/diff/20001/src/gpu/GrInOrderDrawBuffer.h File src/gpu/GrInOrderDrawBuffer.h (right): https://codereview.chromium.org/709133003/diff/20001/src/gpu/GrInOrderDrawBuffer.h#newcode310 src/gpu/GrInOrderDrawBuffer.h:310: SkAutoTUnref<const GrOptDrawState> fCurrentOptDrawState; On 2014/11/10 16:06:15, bsalomon wrote: > ...
6 years, 1 month ago (2014-11-10 16:27:19 UTC) #4
bsalomon
https://codereview.chromium.org/709133003/diff/20001/src/gpu/GrInOrderDrawBuffer.h File src/gpu/GrInOrderDrawBuffer.h (right): https://codereview.chromium.org/709133003/diff/20001/src/gpu/GrInOrderDrawBuffer.h#newcode310 src/gpu/GrInOrderDrawBuffer.h:310: SkAutoTUnref<const GrOptDrawState> fCurrentOptDrawState; On 2014/11/10 16:27:18, joshualitt wrote: > ...
6 years, 1 month ago (2014-11-10 16:36:02 UTC) #5
joshualitt
feedback incorporated
6 years, 1 month ago (2014-11-10 17:01:12 UTC) #6
bsalomon
lgtm
6 years, 1 month ago (2014-11-10 17:55:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/709133003/40001
6 years, 1 month ago (2014-11-10 23:55:14 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 00:03:27 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/d53a82706ebd227bc0e4dd535118cdd8298131bd

Powered by Google App Engine
This is Rietveld 408576698