Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings

This step is to move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings
(Ref: binding-methods changed:
LocalDOMWindow* toDOMWindow(v8::Handle<v8::Value>, v8::Isolate*)
virtual v8::Handle<v8::Object> associateWithWrapper(const WrapperTypeInfo*, v8::Handle<v8::Object> wrapper, v8::Isolate*))

BUG=424446
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185586

[RAGHURAM, 2014-11-11 12:14:12]

r.nagaraj@samsung.com changed reviewers:
+ haraken@chromium.org

[RAGHURAM, 2014-11-11 12:14:13]

Please Review.
One query: one of the methods is in WebKit/Source/modules folder
(so any method within the WebKit/Source needs a change or should I just confine
the search to WebKit/Source/bindings??)

Thanks & Regards

[haraken, 2014-11-11 13:01:29]

LGTM.

> One query: one of the methods is in WebKit/Source/modules folder
> (so any method within the WebKit/Source needs a change or should I just
confine
> the search to WebKit/Source/bindings??)

All methods in Source/ :)

[RAGHURAM, 2014-11-11 13:33:41]

The CQ bit was checked by r.nagaraj@samsung.com

[commit-bot: I haz the power, 2014-11-11 13:34:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/698023005/1

[commit-bot: I haz the power, 2014-11-11 13:34:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-11 13:34:40]

Failed to apply patch for Source/bindings/core/v8/ScriptProfiler.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/core/v8/ScriptProfiler.cpp
  Hunk #1 FAILED at 165.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/bindings/core/v8/ScriptProfiler.cpp.rej

Patch:       Source/bindings/core/v8/ScriptProfiler.cpp
Index: Source/bindings/core/v8/ScriptProfiler.cpp
diff --git a/Source/bindings/core/v8/ScriptProfiler.cpp
b/Source/bindings/core/v8/ScriptProfiler.cpp
index
35137e816159c9dd1059b8fbb83f837207953b80..247a513fe72af6b41c94782061acc0a466a5fecc
100644
--- a/Source/bindings/core/v8/ScriptProfiler.cpp
+++ b/Source/bindings/core/v8/ScriptProfiler.cpp
@@ -165,7 +165,7 @@ class GlobalObjectNameResolver final : public
v8::HeapProfiler::ObjectNameResolv
 public:
     virtual const char* GetName(v8::Handle<v8::Object> object) override
     {
-        LocalDOMWindow* window = toDOMWindow(object,
v8::Isolate::GetCurrent());
+        LocalDOMWindow* window = toDOMWindow(v8::Isolate::GetCurrent(),
object);
         if (!window)
             return 0;
         CString url = window->document()->url().string().utf8();

[RAGHURAM, 2014-11-19 06:47:52]

The CQ bit was checked by r.nagaraj@samsung.com

[commit-bot: I haz the power, 2014-11-19 06:48:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/698023005/1

[commit-bot: I haz the power, 2014-11-19 06:49:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-19 06:49:17]

Failed to apply patch for Source/bindings/core/v8/ScriptProfiler.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/bindings/core/v8/ScriptProfiler.cpp
  Hunk #1 FAILED at 165.
  1 out of 1 hunk FAILED -- saving rejects to file
Source/bindings/core/v8/ScriptProfiler.cpp.rej

Patch:       Source/bindings/core/v8/ScriptProfiler.cpp
Index: Source/bindings/core/v8/ScriptProfiler.cpp
diff --git a/Source/bindings/core/v8/ScriptProfiler.cpp
b/Source/bindings/core/v8/ScriptProfiler.cpp
index
35137e816159c9dd1059b8fbb83f837207953b80..247a513fe72af6b41c94782061acc0a466a5fecc
100644
--- a/Source/bindings/core/v8/ScriptProfiler.cpp
+++ b/Source/bindings/core/v8/ScriptProfiler.cpp
@@ -165,7 +165,7 @@ class GlobalObjectNameResolver final : public
v8::HeapProfiler::ObjectNameResolv
 public:
     virtual const char* GetName(v8::Handle<v8::Object> object) override
     {
-        LocalDOMWindow* window = toDOMWindow(object,
v8::Isolate::GetCurrent());
+        LocalDOMWindow* window = toDOMWindow(v8::Isolate::GetCurrent(),
object);
         if (!window)
             return 0;
         CString url = window->document()->url().string().utf8();

[RAGHURAM, 2014-11-19 10:51:18]

The CQ bit was checked by r.nagaraj@samsung.com

[commit-bot: I haz the power, 2014-11-19 10:52:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/698023005/20001

[commit-bot: I haz the power, 2014-11-19 11:42:31]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185586