Source/bindings/core/v8/V8Binding.h - Issue 698023005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8Binding.h

Issue 698023005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/V8Binding.h

diff --git a/Source/bindings/core/v8/V8Binding.h b/Source/bindings/core/v8/V8Binding.h

index 86372bfa0f2837794b40ef230f83be23c5a2f184..472317bcc23d2e370ae7a51f27764e6fa1ba843d 100644

--- a/Source/bindings/core/v8/V8Binding.h

+++ b/Source/bindings/core/v8/V8Binding.h

@@ -1095,7 +1095,7 @@ struct NativeValueTraits<Vector<T> > {

v8::Isolate* toIsolate(ExecutionContext*);

v8::Isolate* toIsolate(LocalFrame*);

-DOMWindow* toDOMWindow(v8::Handle<v8::Value>, v8::Isolate*);

+DOMWindow* toDOMWindow(v8::Isolate*, v8::Handle<v8::Value>);

DOMWindow* toDOMWindow(v8::Handle<v8::Context>);

LocalDOMWindow* enteredDOMWindow(v8::Isolate*);

LocalDOMWindow* currentDOMWindow(v8::Isolate*);

« no previous file with comments | « Source/bindings/core/v8/ScriptWrappable.cpp ('k') | Source/bindings/core/v8/V8Binding.cpp » ('j') | no next file with comments »