Source/bindings/scripts/v8_types.py - Issue 698023005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 698023005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_types.py

diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py

index c210a36908bcddc1390056b7a45bf13b218487c7..006b60bf17ade4d2747da92d5fdd6b90ce118085 100644

--- a/Source/bindings/scripts/v8_types.py

+++ b/Source/bindings/scripts/v8_types.py

@@ -477,7 +477,7 @@ V8_VALUE_TO_CPP_VALUE = {

'Promise': 'ScriptPromise::cast(ScriptState::current({isolate}), {v8_value})',

'SerializedScriptValue': 'SerializedScriptValue::create({v8_value}, 0, 0, exceptionState, {isolate})',

'ScriptValue': 'ScriptValue(ScriptState::current({isolate}), {v8_value})',

- 'Window': 'toDOMWindow({v8_value}, {isolate})',

+ 'Window': 'toDOMWindow({isolate}, {v8_value})',

'XPathNSResolver': 'toXPathNSResolver({isolate}, {v8_value})',

}

« no previous file with comments | « Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp ('k') | Source/bindings/templates/interface.cpp » ('j') | no next file with comments »