Source/bindings/tests/results/core/V8DataView.cpp - Issue 698023005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8DataView.cpp

Issue 698023005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8ArrayBuffer.cpp ('k') | Source/bindings/tests/results/core/V8TestInterface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8DataView.cpp

diff --git a/Source/bindings/tests/results/core/V8DataView.cpp b/Source/bindings/tests/results/core/V8DataView.cpp

index 5df48a9f70f03c11f2c453f0e984b94183678337..bb11bd2b1d2c2086877c7ac96ab12fe189d5ced6 100644

--- a/Source/bindings/tests/results/core/V8DataView.cpp

+++ b/Source/bindings/tests/results/core/V8DataView.cpp

@@ -42,7 +42,7 @@ TestDataView* V8DataView::toImpl(v8::Handle<v8::Object> object)

v8::Handle<v8::DataView> v8View = object.As<v8::DataView>();

RefPtr<TestDataView> typedArray = TestDataView::create(V8ArrayBuffer::toImpl(v8View->Buffer()), v8View->ByteOffset(), v8View->ByteLength());

- typedArray->associateWithWrapper(typedArray->wrapperTypeInfo(), object, v8::Isolate::GetCurrent());

+ typedArray->associateWithWrapper(v8::Isolate::GetCurrent(), typedArray->wrapperTypeInfo(), object);

return typedArray->toImpl<TestDataView>();

}

« no previous file with comments | « Source/bindings/tests/results/core/V8ArrayBuffer.cpp ('k') | Source/bindings/tests/results/core/V8TestInterface.cpp » ('j') | no next file with comments »