Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: Source/bindings/tests/results/core/V8TestObject.cpp

Issue 698023005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestObject.cpp
diff --git a/Source/bindings/tests/results/core/V8TestObject.cpp b/Source/bindings/tests/results/core/V8TestObject.cpp
index d9fd89f9d1b97d12b881d72a2f6e9814cba3b51b..1e7c31c495556f77e75181145e6aeb165cd0e9a3 100644
--- a/Source/bindings/tests/results/core/V8TestObject.cpp
+++ b/Source/bindings/tests/results/core/V8TestObject.cpp
@@ -1081,7 +1081,7 @@ static void windowAttributeAttributeSetter(v8::Local<v8::Value> v8Value, const v
{
v8::Handle<v8::Object> holder = info.Holder();
TestObject* impl = V8TestObject::toImpl(holder);
- DOMWindow* cppValue = toDOMWindow(v8Value, info.GetIsolate());
+ DOMWindow* cppValue = toDOMWindow(info.GetIsolate(), v8Value);
impl->setWindowAttribute(WTF::getPtr(cppValue));
}
@@ -8410,7 +8410,7 @@ static void promiseOverloadMethod2Method(const v8::FunctionCallbackInfo<v8::Valu
DOMWindow* arg1;
double arg2;
{
- arg1 = toDOMWindow(info[0], info.GetIsolate());
+ arg1 = toDOMWindow(info.GetIsolate(), info[0]);
TONATIVE_VOID_EXCEPTIONSTATE_PROMISE_INTERNAL(arg2, toDouble(info[1], exceptionState), exceptionState, info, ScriptState::current(info.GetIsolate()));
}
v8SetReturnValue(info, impl->promiseOverloadMethod(arg1, arg2).v8Value());
« no previous file with comments | « Source/bindings/tests/results/core/V8TestNode.cpp ('k') | Source/bindings/tests/results/core/V8TestTypedefs.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698