Source/bindings/core/v8/custom/V8MessageEventCustom.cpp - Issue 698023005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

Issue 698023005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp ('k') | Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp b/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

index 5b718c8693f445d18d15669f6b450e6e2afd877a..2e19b5650fcba20949ee081ca7949f1c57fe9bc6 100644

--- a/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

@@ -112,7 +112,7 @@ void V8MessageEvent::initMessageEventMethodCustom(const v8::FunctionCallbackInfo

v8::Handle<v8::Value> dataArg = info[3];

TOSTRING_VOID(V8StringResource<>, originArg, info[4]);

TOSTRING_VOID(V8StringResource<>, lastEventIdArg, info[5]);

- DOMWindow* sourceArg = toDOMWindow(info[6], info.GetIsolate());

+ DOMWindow* sourceArg = toDOMWindow(info.GetIsolate(), info[6]);

OwnPtrWillBeRawPtr<MessagePortArray> portArray = nullptr;

const int portArrayIndex = 7;

if (!isUndefinedOrNull(info[portArrayIndex])) {