Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 697663003: [turbofan] Also optimize unsigned division by constant. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Also optimize unsigned division by constant. TEST=cctest,mjsunit,unittests R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25061

Patch Set 1 #

Patch Set 2 : Updates #

Patch Set 3 : Slight improvement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+393 lines, -177 lines) Patch
M src/arm64/macro-assembler-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm64/macro-assembler-arm64-inl.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-codes-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/change-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-codes-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 2 chunks +30 lines, -18 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 7 chunks +54 lines, -18 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 4 chunks +10 lines, -6 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +6 lines, -1 line 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 1 chunk +12 lines, -1 line 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 2 5 chunks +38 lines, -24 lines 0 comments Download
M src/x64/assembler-x64.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M src/x64/assembler-x64.cc View 1 2 chunks +25 lines, -1 line 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 3 chunks +35 lines, -20 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + test/mjsunit/asm/uint32div.js View 1 chunk +7 lines, -11 lines 0 comments Download
A + test/mjsunit/asm/uint32mod.js View 1 chunk +7 lines, -11 lines 0 comments Download
M test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 16 chunks +69 lines, -59 lines 0 comments Download
M test/unittests/compiler/x64/instruction-selector-x64-unittest.cc View 1 chunk +21 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years, 1 month ago (2014-11-03 09:01:40 UTC) #2
Jarin
lgtm
6 years, 1 month ago (2014-11-03 09:52:45 UTC) #3
Benedikt Meurer
6 years, 1 month ago (2014-11-03 10:05:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 25061 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698