[turbofan] Also optimize unsigned division by constant.

test/unittests/compiler/machine-operator-reducer-unittest.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/base/bits.h"
 #include "src/base/division-by-constant.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/machine-operator-reducer.h"
 #include "src/compiler/typer.h"
 #include "test/unittests/compiler/graph-unittest.h"
@@ skipping 662 matching lines @@
 }
 
 
 // -----------------------------------------------------------------------------
 // Int32Div
 
 
 TEST_F(MachineOperatorReducerTest, Int32DivWithConstant) {
   Node* const p0 = Parameter(0);
   {
-    Reduction const r =
-        Reduce(graph()->NewNode(machine()->Int32Div(), p0, Int32Constant(0)));
+    Reduction const r = Reduce(graph()->NewNode(
+        machine()->Int32Div(), p0, Int32Constant(0), graph()->start()));
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(r.replacement(), IsInt32Constant(0));
   }
   {
-    Reduction const r =
-        Reduce(graph()->NewNode(machine()->Int32Div(), p0, Int32Constant(1)));
+    Reduction const r = Reduce(graph()->NewNode(
+        machine()->Int32Div(), p0, Int32Constant(1), graph()->start()));
     ASSERT_TRUE(r.Changed());
     EXPECT_EQ(r.replacement(), p0);
   }
   {
-    Reduction const r =
-        Reduce(graph()->NewNode(machine()->Int32Div(), p0, Int32Constant(-1)));
+    Reduction const r = Reduce(graph()->NewNode(
+        machine()->Int32Div(), p0, Int32Constant(-1), graph()->start()));
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(r.replacement(), IsInt32Sub(IsInt32Constant(0), p0));
   }
   {
-    Reduction const r =
-        Reduce(graph()->NewNode(machine()->Int32Div(), p0, Int32Constant(2)));
+    Reduction const r = Reduce(graph()->NewNode(
+        machine()->Int32Div(), p0, Int32Constant(2), graph()->start()));
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(
         r.replacement(),
         IsWord32Sar(IsInt32Add(IsWord32Shr(p0, IsInt32Constant(31)), p0),
                     IsInt32Constant(1)));
   }
   {
-    Reduction const r =
-        Reduce(graph()->NewNode(machine()->Int32Div(), p0, Int32Constant(-2)));
+    Reduction const r = Reduce(graph()->NewNode(
+        machine()->Int32Div(), p0, Int32Constant(-2), graph()->start()));
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(
         r.replacement(),
         IsInt32Sub(
             IsInt32Constant(0),
             IsWord32Sar(IsInt32Add(IsWord32Shr(p0, IsInt32Constant(31)), p0),
                         IsInt32Constant(1))));
   }
   TRACED_FORRANGE(int32_t, shift, 2, 30) {
-    Reduction const r = Reduce(
-        graph()->NewNode(machine()->Int32Div(), p0, Int32Constant(1 << shift)));
+    Reduction const r =
+        Reduce(graph()->NewNode(machine()->Int32Div(), p0,
+                                Int32Constant(1 << shift), graph()->start()));
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(
         r.replacement(),
         IsWord32Sar(IsInt32Add(IsWord32Shr(IsWord32Sar(p0, IsInt32Constant(31)),
                                            IsInt32Constant(32 - shift)),
                                p0),
                     IsInt32Constant(shift)));
   }
   TRACED_FORRANGE(int32_t, shift, 2, 31) {
     Reduction const r = Reduce(graph()->NewNode(
         machine()->Int32Div(), p0,
-        Uint32Constant(bit_cast<uint32_t, int32_t>(-1) << shift)));
+        Uint32Constant(bit_cast<uint32_t, int32_t>(-1) << shift),
+        graph()->start()));
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(
         r.replacement(),
         IsInt32Sub(
             IsInt32Constant(0),
             IsWord32Sar(
                 IsInt32Add(IsWord32Shr(IsWord32Sar(p0, IsInt32Constant(31)),
                                        IsInt32Constant(32 - shift)),
                            p0),
                 IsInt32Constant(shift))));
   }
   TRACED_FOREACH(int32_t, divisor, kInt32Values) {
     if (divisor < 0) {
       if (base::bits::IsPowerOfTwo32(-divisor)) continue;
-      Reduction const r = Reduce(
-          graph()->NewNode(machine()->Int32Div(), p0, Int32Constant(divisor)));
+      Reduction const r = Reduce(graph()->NewNode(
+          machine()->Int32Div(), p0, Int32Constant(divisor), graph()->start()));
       ASSERT_TRUE(r.Changed());
       EXPECT_THAT(r.replacement(), IsInt32Sub(IsInt32Constant(0),
                                               IsTruncatingDiv(p0, -divisor)));
     } else if (divisor > 0) {
       if (base::bits::IsPowerOfTwo32(divisor)) continue;
-      Reduction const r = Reduce(
-          graph()->NewNode(machine()->Int32Div(), p0, Int32Constant(divisor)));
+      Reduction const r = Reduce(graph()->NewNode(
+          machine()->Int32Div(), p0, Int32Constant(divisor), graph()->start()));
       ASSERT_TRUE(r.Changed());
       EXPECT_THAT(r.replacement(), IsTruncatingDiv(p0, divisor));
     }
   }
 }
 
 
 TEST_F(MachineOperatorReducerTest, Int32DivWithParameters) {
   Node* const p0 = Parameter(0);
-  Reduction const r = Reduce(graph()->NewNode(machine()->Int32Div(), p0, p0));
+  Reduction const r =
+      Reduce(graph()->NewNode(machine()->Int32Div(), p0, p0, graph()->start()));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(
       r.replacement(),
       IsWord32Equal(IsWord32Equal(p0, IsInt32Constant(0)), IsInt32Constant(0)));
 }
 
 
 // -----------------------------------------------------------------------------
 // Uint32Div
 
 
 TEST_F(MachineOperatorReducerTest, Uint32DivWithConstant) {
   Node* const p0 = Parameter(0);
   {
-    Reduction const r =
-        Reduce(graph()->NewNode(machine()->Uint32Div(), Int32Constant(0), p0));
+    Reduction const r = Reduce(graph()->NewNode(
+        machine()->Uint32Div(), Int32Constant(0), p0, graph()->start()));
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(r.replacement(), IsInt32Constant(0));
   }
   {
-    Reduction const r =
-        Reduce(graph()->NewNode(machine()->Uint32Div(), p0, Int32Constant(0)));
+    Reduction const r = Reduce(graph()->NewNode(
+        machine()->Uint32Div(), p0, Int32Constant(0), graph()->start()));
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(r.replacement(), IsInt32Constant(0));
   }
   {
-    Reduction const r =
-        Reduce(graph()->NewNode(machine()->Uint32Div(), p0, Int32Constant(1)));
+    Reduction const r = Reduce(graph()->NewNode(
+        machine()->Uint32Div(), p0, Int32Constant(1), graph()->start()));
     ASSERT_TRUE(r.Changed());
     EXPECT_EQ(r.replacement(), p0);
   }
   TRACED_FOREACH(uint32_t, dividend, kUint32Values) {
     TRACED_FOREACH(uint32_t, divisor, kUint32Values) {
-      Reduction const r = Reduce(graph()->NewNode(machine()->Uint32Div(),
-                                                  Uint32Constant(dividend),
-                                                  Uint32Constant(divisor)));
+      Reduction const r = Reduce(
+          graph()->NewNode(machine()->Uint32Div(), Uint32Constant(dividend),
+                           Uint32Constant(divisor), graph()->start()));
       ASSERT_TRUE(r.Changed());
       EXPECT_THAT(r.replacement(),
                   IsInt32Constant(bit_cast<int32_t>(
                       base::bits::UnsignedDiv32(dividend, divisor))));
     }
   }
   TRACED_FORRANGE(uint32_t, shift, 1, 31) {
-    Reduction const r = Reduce(graph()->NewNode(machine()->Uint32Div(), p0,
-                                                Uint32Constant(1u << shift)));
+    Reduction const r =
+        Reduce(graph()->NewNode(machine()->Uint32Div(), p0,
+                                Uint32Constant(1u << shift), graph()->start()));
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(r.replacement(),
                 IsWord32Shr(p0, IsInt32Constant(bit_cast<int32_t>(shift))));
   }
 }
 
 
 TEST_F(MachineOperatorReducerTest, Uint32DivWithParameters) {
   Node* const p0 = Parameter(0);
-  Reduction const r = Reduce(graph()->NewNode(machine()->Uint32Div(), p0, p0));
+  Reduction const r = Reduce(
+      graph()->NewNode(machine()->Uint32Div(), p0, p0, graph()->start()));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(
       r.replacement(),
       IsWord32Equal(IsWord32Equal(p0, IsInt32Constant(0)), IsInt32Constant(0)));
 }
 
 
 // -----------------------------------------------------------------------------
 // Int32Mod
 
 
 TEST_F(MachineOperatorReducerTest, Int32ModWithConstant) {
   Node* const p0 = Parameter(0);
   {
-    Reduction const r =
-        Reduce(graph()->NewNode(machine()->Int32Mod(), Int32Constant(0), p0));
+    Reduction const r = Reduce(graph()->NewNode(
+        machine()->Int32Mod(), Int32Constant(0), p0, graph()->start()));
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(r.replacement(), IsInt32Constant(0));
   }
   {
-    Reduction const r =
-        Reduce(graph()->NewNode(machine()->Int32Mod(), p0, Int32Constant(0)));
+    Reduction const r = Reduce(graph()->NewNode(
+        machine()->Int32Mod(), p0, Int32Constant(0), graph()->start()));
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(r.replacement(), IsInt32Constant(0));
   }
   {
-    Reduction const r =
-        Reduce(graph()->NewNode(machine()->Int32Mod(), p0, Int32Constant(1)));
+    Reduction const r = Reduce(graph()->NewNode(
+        machine()->Int32Mod(), p0, Int32Constant(1), graph()->start()));
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(r.replacement(), IsInt32Constant(0));
   }
   {
-    Reduction const r =
-        Reduce(graph()->NewNode(machine()->Int32Mod(), p0, Int32Constant(-1)));
+    Reduction const r = Reduce(graph()->NewNode(
+        machine()->Int32Mod(), p0, Int32Constant(-1), graph()->start()));
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(r.replacement(), IsInt32Constant(0));
   }
   TRACED_FOREACH(int32_t, dividend, kInt32Values) {
     TRACED_FOREACH(int32_t, divisor, kInt32Values) {
-      Reduction const r = Reduce(graph()->NewNode(machine()->Int32Mod(),
-                                                  Int32Constant(dividend),
-                                                  Int32Constant(divisor)));
+      Reduction const r = Reduce(
+          graph()->NewNode(machine()->Int32Mod(), Int32Constant(dividend),
+                           Int32Constant(divisor), graph()->start()));
       ASSERT_TRUE(r.Changed());
       EXPECT_THAT(r.replacement(),
                   IsInt32Constant(base::bits::SignedMod32(dividend, divisor)));
     }
   }
   TRACED_FORRANGE(int32_t, shift, 1, 30) {
-    Reduction const r = Reduce(
-        graph()->NewNode(machine()->Int32Mod(), p0, Int32Constant(1 << shift)));
+    Reduction const r =
+        Reduce(graph()->NewNode(machine()->Int32Mod(), p0,
+                                Int32Constant(1 << shift), graph()->start()));
     ASSERT_TRUE(r.Changed());
 
     Capture<Node*> branch;
     Node* const phi = r.replacement();
     int32_t const mask = (1 << shift) - 1;
     EXPECT_THAT(
         phi, IsPhi(kMachInt32,
                    IsInt32Sub(IsInt32Constant(0),
                               IsWord32And(IsInt32Sub(IsInt32Constant(0), p0),
                                           IsInt32Constant(mask))),
                    IsWord32And(p0, IsInt32Constant(mask)),
                    IsMerge(IsIfTrue(CaptureEq(&branch)),
                            IsIfFalse(AllOf(
                                CaptureEq(&branch),
                                IsBranch(IsInt32LessThan(p0, IsInt32Constant(0)),
                                         graph()->start()))))));
   }
   TRACED_FORRANGE(int32_t, shift, 1, 31) {
     Reduction const r = Reduce(graph()->NewNode(
         machine()->Int32Mod(), p0,
-        Uint32Constant(bit_cast<uint32_t, int32_t>(-1) << shift)));
+        Uint32Constant(bit_cast<uint32_t, int32_t>(-1) << shift),
+        graph()->start()));
     ASSERT_TRUE(r.Changed());
 
     Capture<Node*> branch;
     Node* const phi = r.replacement();
     int32_t const mask = bit_cast<int32_t, uint32_t>((1U << shift) - 1);
     EXPECT_THAT(
         phi, IsPhi(kMachInt32,
                    IsInt32Sub(IsInt32Constant(0),
                               IsWord32And(IsInt32Sub(IsInt32Constant(0), p0),
                                           IsInt32Constant(mask))),
                    IsWord32And(p0, IsInt32Constant(mask)),
                    IsMerge(IsIfTrue(CaptureEq(&branch)),
                            IsIfFalse(AllOf(
                                CaptureEq(&branch),
                                IsBranch(IsInt32LessThan(p0, IsInt32Constant(0)),
                                         graph()->start()))))));
   }
   TRACED_FOREACH(int32_t, divisor, kInt32Values) {
     if (divisor == 0 || base::bits::IsPowerOfTwo32(Abs(divisor))) continue;
-    Reduction const r = Reduce(
-        graph()->NewNode(machine()->Int32Mod(), p0, Int32Constant(divisor)));
+    Reduction const r = Reduce(graph()->NewNode(
+        machine()->Int32Mod(), p0, Int32Constant(divisor), graph()->start()));
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(r.replacement(),
                 IsInt32Sub(p0, IsInt32Mul(IsTruncatingDiv(p0, Abs(divisor)),
                                           IsInt32Constant(Abs(divisor)))));
   }
 }
 
 
 TEST_F(MachineOperatorReducerTest, Int32ModWithParameters) {
   Node* const p0 = Parameter(0);
-  Reduction const r = Reduce(graph()->NewNode(machine()->Int32Mod(), p0, p0));
+  Reduction const r =
+      Reduce(graph()->NewNode(machine()->Int32Mod(), p0, p0, graph()->start()));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(), IsInt32Constant(0));
 }
 
 
 // -----------------------------------------------------------------------------
 // Uint32Mod
 
 
 TEST_F(MachineOperatorReducerTest, Uint32ModWithConstant) {
   Node* const p0 = Parameter(0);
   {
-    Reduction const r =
-        Reduce(graph()->NewNode(machine()->Uint32Mod(), p0, Int32Constant(0)));
+    Reduction const r = Reduce(graph()->NewNode(
+        machine()->Uint32Mod(), p0, Int32Constant(0), graph()->start()));
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(r.replacement(), IsInt32Constant(0));
   }
   {
-    Reduction const r =
-        Reduce(graph()->NewNode(machine()->Uint32Mod(), Int32Constant(0), p0));
+    Reduction const r = Reduce(graph()->NewNode(
+        machine()->Uint32Mod(), Int32Constant(0), p0, graph()->start()));
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(r.replacement(), IsInt32Constant(0));
   }
   {
-    Reduction const r =
-        Reduce(graph()->NewNode(machine()->Uint32Mod(), p0, Int32Constant(1)));
+    Reduction const r = Reduce(graph()->NewNode(
+        machine()->Uint32Mod(), p0, Int32Constant(1), graph()->start()));
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(r.replacement(), IsInt32Constant(0));
   }
   TRACED_FOREACH(uint32_t, dividend, kUint32Values) {
     TRACED_FOREACH(uint32_t, divisor, kUint32Values) {
-      Reduction const r = Reduce(graph()->NewNode(machine()->Uint32Mod(),
-                                                  Uint32Constant(dividend),
-                                                  Uint32Constant(divisor)));
+      Reduction const r = Reduce(
+          graph()->NewNode(machine()->Uint32Mod(), Uint32Constant(dividend),
+                           Uint32Constant(divisor), graph()->start()));
       ASSERT_TRUE(r.Changed());
       EXPECT_THAT(r.replacement(),
                   IsInt32Constant(bit_cast<int32_t>(
                       base::bits::UnsignedMod32(dividend, divisor))));
     }
   }
   TRACED_FORRANGE(uint32_t, shift, 1, 31) {
-    Reduction const r = Reduce(graph()->NewNode(machine()->Uint32Mod(), p0,
-                                                Uint32Constant(1u << shift)));
+    Reduction const r =
+        Reduce(graph()->NewNode(machine()->Uint32Mod(), p0,
+                                Uint32Constant(1u << shift), graph()->start()));
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(r.replacement(),
                 IsWord32And(p0, IsInt32Constant(
                                     bit_cast<int32_t>((1u << shift) - 1u))));
   }
 }
 
 
 TEST_F(MachineOperatorReducerTest, Uint32ModWithParameters) {
   Node* const p0 = Parameter(0);
-  Reduction const r = Reduce(graph()->NewNode(machine()->Uint32Mod(), p0, p0));
+  Reduction const r = Reduce(
+      graph()->NewNode(machine()->Uint32Mod(), p0, p0, graph()->start()));
   ASSERT_TRUE(r.Changed());
   EXPECT_THAT(r.replacement(), IsInt32Constant(0));
 }
 
 
 // -----------------------------------------------------------------------------
 // Int32AddWithOverflow
 
 
 TEST_F(MachineOperatorReducerTest, Int32AddWithOverflowWithZero) {
@@ skipping 149 matching lines @@
     Reduction r = Reduce(node);
     ASSERT_TRUE(r.Changed());
     EXPECT_THAT(r.replacement(),
                 IsStore(rep, base, index, value, effect, control));
   }
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8