src/compiler/change-lowering.cc - Issue 697663003: [turbofan] Also optimize unsigned division by constant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/change-lowering.cc

Issue 697663003: [turbofan] Also optimize unsigned division by constant. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Slight improvement Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/change-lowering.cc

diff --git a/src/compiler/change-lowering.cc b/src/compiler/change-lowering.cc

index 3b3998086422500e0962bc9c313d04dbc0af018b..0b4a39952ae69bab681a32ac0d590a986f8ab9cd 100644

--- a/src/compiler/change-lowering.cc

+++ b/src/compiler/change-lowering.cc

@@ -53,7 +53,7 @@ Node* ChangeLowering::HeapNumberValueIndexConstant() {

Node* ChangeLowering::SmiMaxValueConstant() {

const int smi_value_size = machine()->Is32() ? SmiTagging<4>::SmiValueSize()

: SmiTagging<8>::SmiValueSize();

- return jsgraph()->IntPtrConstant(

+ return jsgraph()->Int32Constant(

-(static_cast<int>(0xffffffffu << (smi_value_size - 1)) + 1));

}