Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 695813003: Add class GrGLTextureRenderTarget for GL texture/rendertarget objects (Closed)

Created:
6 years, 1 month ago by bsalomon
Modified:
5 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add class GrGLTextureRenderTarget for GL texture/rendertarget objects BUG=skia:2889 Committed: https://skia.googlesource.com/skia/+/37dd331b20a92ce79cc26556e065dec98a66cb0b

Patch Set 1 #

Patch Set 2 : working #

Patch Set 3 : cleanup #

Total comments: 14

Patch Set 4 : Address comments, remove delegated cons #

Total comments: 4

Patch Set 5 : fix con order warnings #

Patch Set 6 : forgot to save file #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -222 lines) Patch
M gyp/gpu.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrGpuResource.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M include/gpu/GrGpuResourceRef.h View 1 2 3 chunks +46 lines, -1 line 0 comments Download
M include/gpu/GrRenderTarget.h View 1 3 chunks +4 lines, -29 lines 1 comment Download
M include/gpu/GrSurface.h View 2 chunks +4 lines, -8 lines 0 comments Download
M include/gpu/GrTexture.h View 4 chunks +1 line, -14 lines 0 comments Download
M src/effects/SkColorCubeFilter.cpp View 1 1 chunk +6 lines, -5 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 3 2 chunks +7 lines, -3 lines 0 comments Download
M src/gpu/GrDrawState.h View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/GrOptDrawState.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/GrRenderTarget.cpp View 1 1 chunk +0 lines, -14 lines 0 comments Download
M src/gpu/GrResourceCache.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrResourceCache2.h View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/GrTexture.cpp View 3 chunks +0 lines, -21 lines 0 comments Download
M src/gpu/gl/GrGLRenderTarget.h View 1 2 3 4 chunks +18 lines, -23 lines 0 comments Download
M src/gpu/gl/GrGLRenderTarget.cpp View 1 2 3 4 5 3 chunks +33 lines, -37 lines 0 comments Download
M src/gpu/gl/GrGLTexture.h View 1 2 3 4 chunks +11 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGLTexture.cpp View 1 2 3 4 1 chunk +15 lines, -31 lines 0 comments Download
A src/gpu/gl/GrGLTextureRenderTarget.h View 1 2 3 4 1 chunk +58 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 1 2 3 7 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
bsalomon
6 years, 1 month ago (2014-10-31 19:36:08 UTC) #2
robertphillips
https://codereview.chromium.org/695813003/diff/40001/src/gpu/gl/GrGLRenderTarget.cpp File src/gpu/gl/GrGLRenderTarget.cpp (right): https://codereview.chromium.org/695813003/diff/40001/src/gpu/gl/GrGLRenderTarget.cpp#newcode21 src/gpu/gl/GrGLRenderTarget.cpp:21: Derived) move GrSurface ctor call to its own line ...
6 years, 1 month ago (2014-11-03 13:58:55 UTC) #3
bsalomon
https://codereview.chromium.org/695813003/diff/40001/src/gpu/gl/GrGLRenderTarget.cpp File src/gpu/gl/GrGLRenderTarget.cpp (right): https://codereview.chromium.org/695813003/diff/40001/src/gpu/gl/GrGLRenderTarget.cpp#newcode21 src/gpu/gl/GrGLRenderTarget.cpp:21: Derived) On 2014/11/03 13:58:54, robertphillips wrote: > move GrSurface ...
6 years, 1 month ago (2014-11-03 15:20:15 UTC) #4
robertphillips
lgtm + a question https://codereview.chromium.org/695813003/diff/60001/src/gpu/gl/GrGLRenderTarget.cpp File src/gpu/gl/GrGLRenderTarget.cpp (right): https://codereview.chromium.org/695813003/diff/60001/src/gpu/gl/GrGLRenderTarget.cpp#newcode22 src/gpu/gl/GrGLRenderTarget.cpp:22: Is this ctor still useful ...
6 years, 1 month ago (2014-11-03 15:52:23 UTC) #5
bsalomon
https://codereview.chromium.org/695813003/diff/60001/src/gpu/gl/GrGLRenderTarget.cpp File src/gpu/gl/GrGLRenderTarget.cpp (right): https://codereview.chromium.org/695813003/diff/60001/src/gpu/gl/GrGLRenderTarget.cpp#newcode22 src/gpu/gl/GrGLRenderTarget.cpp:22: On 2014/11/03 15:52:23, robertphillips wrote: > Is this ctor ...
6 years, 1 month ago (2014-11-03 15:56:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695813003/60001
6 years, 1 month ago (2014-11-03 15:57:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/383)
6 years, 1 month ago (2014-11-03 15:59:48 UTC) #10
robertphillips
https://codereview.chromium.org/695813003/diff/60001/src/gpu/gl/GrGLRenderTarget.cpp File src/gpu/gl/GrGLRenderTarget.cpp (right): https://codereview.chromium.org/695813003/diff/60001/src/gpu/gl/GrGLRenderTarget.cpp#newcode22 src/gpu/gl/GrGLRenderTarget.cpp:22: On 2014/11/03 15:56:57, bsalomon wrote: > On 2014/11/03 15:52:23, ...
6 years, 1 month ago (2014-11-03 16:00:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695813003/80001
6 years, 1 month ago (2014-11-03 16:30:13 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/389)
6 years, 1 month ago (2014-11-03 16:31:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/695813003/100001
6 years, 1 month ago (2014-11-03 16:35:17 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:100001) as 37dd331b20a92ce79cc26556e065dec98a66cb0b
6 years, 1 month ago (2014-11-03 16:47:27 UTC) #18
brucedawson
5 years, 5 months ago (2015-07-15 17:27:33 UTC) #20
Message was sent while issue was closed. 
https://codereview.chromium.org/695813003/diff/100001/include/gpu/GrRenderTar...
File include/gpu/GrRenderTarget.h (right):

https://codereview.chromium.org/695813003/diff/100001/include/gpu/GrRenderTar...
include/gpu/GrRenderTarget.h:23: class GrRenderTarget : virtual public GrSurface
{
Note that the use of virtual here makes the call to the INHERITED constructor a
NOP. See crbug.com/510497

Powered by Google App Engine
This is Rietveld 408576698