Standardize usage of virtual/override/final specifiers.

Standardize usage of virtual/override/final specifiers.

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=jamescook@chromium.org

Committed: https://crrev.com/2227fcd59e80b184db6223735d018a62445a29c9
Cr-Commit-Position: refs/heads/master@{#301590}

[James Cook, 2014-10-27 23:33:53]

lgtm

[dcheng, 2014-10-27 23:34:51]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-10-27 23:38:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/686463004/1

[commit-bot: I haz the power, 2014-10-28 00:52:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-28 00:52:30]

Failed to apply patch for chrome/browser/ui/views/frame/browser_view.h:
While running git apply --index -3 -p1;
  error: patch failed: chrome/browser/ui/views/frame/browser_view.h:331
  Falling back to three-way merge...
  Applied patch to 'chrome/browser/ui/views/frame/browser_view.h' with
conflicts.
  U chrome/browser/ui/views/frame/browser_view.h

Patch:       chrome/browser/ui/views/frame/browser_view.h
Index: chrome/browser/ui/views/frame/browser_view.h
diff --git a/chrome/browser/ui/views/frame/browser_view.h
b/chrome/browser/ui/views/frame/browser_view.h
index
6a0de350525ca1c1d80192c4bb8b5e281b17c56c..f893264b73d0f162e90ba37f2f436c04dceff65c
100644
--- a/chrome/browser/ui/views/frame/browser_view.h
+++ b/chrome/browser/ui/views/frame/browser_view.h
@@ -100,7 +100,7 @@ class BrowserView : public BrowserWindow,
   static const char kViewClassName[];
 
   BrowserView();
-  virtual ~BrowserView();
+  ~BrowserView() override;
 
   // Takes ownership of |browser|.
   void Init(Browser* browser);
@@ -247,83 +247,80 @@ class BrowserView : public BrowserWindow,
   void ToolbarSizeChanged(bool is_animating);
 
   // Overridden from BrowserWindow:
-  virtual void Show() override;
-  virtual void ShowInactive() override;
-  virtual void Hide() override;
-  virtual void SetBounds(const gfx::Rect& bounds) override;
-  virtual void Close() override;
-  virtual void Activate() override;
-  virtual void Deactivate() override;
-  virtual bool IsActive() const override;
-  virtual void FlashFrame(bool flash) override;
-  virtual bool IsAlwaysOnTop() const override;
-  virtual void SetAlwaysOnTop(bool always_on_top) override;
-  virtual gfx::NativeWindow GetNativeWindow() override;
-  virtual BrowserWindowTesting* GetBrowserWindowTesting() override;
-  virtual StatusBubble* GetStatusBubble() override;
-  virtual void UpdateTitleBar() override;
-  virtual void BookmarkBarStateChanged(
+  void Show() override;
+  void ShowInactive() override;
+  void Hide() override;
+  void SetBounds(const gfx::Rect& bounds) override;
+  void Close() override;
+  void Activate() override;
+  void Deactivate() override;
+  bool IsActive() const override;
+  void FlashFrame(bool flash) override;
+  bool IsAlwaysOnTop() const override;
+  void SetAlwaysOnTop(bool always_on_top) override;
+  gfx::NativeWindow GetNativeWindow() override;
+  BrowserWindowTesting* GetBrowserWindowTesting() override;
+  StatusBubble* GetStatusBubble() override;
+  void UpdateTitleBar() override;
+  void BookmarkBarStateChanged(
       BookmarkBar::AnimateChangeType change_type) override;
-  virtual void UpdateDevTools() override;
-  virtual void UpdateLoadingAnimations(bool should_animate) override;
-  virtual void SetStarredState(bool is_starred) override;
-  virtual void SetTranslateIconToggled(bool is_lit) override;
-  virtual void OnActiveTabChanged(content::WebContents* old_contents,
-                                  content::WebContents* new_contents,
-                                  int index,
-                                  int reason) override;
-  virtual void ZoomChangedForActiveTab(bool can_show_bubble) override;
-  virtual gfx::Rect GetRestoredBounds() const override;
-  virtual ui::WindowShowState GetRestoredState() const override;
-  virtual gfx::Rect GetBounds() const override;
-  virtual bool IsMaximized() const override;
-  virtual bool IsMinimized() const override;
-  virtual void Maximize() override;
-  virtual void Minimize() override;
-  virtual void Restore() override;
-  virtual void EnterFullscreen(
-      const GURL& url, FullscreenExitBubbleType bubble_type) override;
-  virtual void ExitFullscreen() override;
-  virtual void UpdateFullscreenExitBubbleContent(
+  void UpdateDevTools() override;
+  void UpdateLoadingAnimations(bool should_animate) override;
+  void SetStarredState(bool is_starred) override;
+  void SetTranslateIconToggled(bool is_lit) override;
+  void OnActiveTabChanged(content::WebContents* old_contents,
+                          content::WebContents* new_contents,
+                          int index,
+                          int reason) override;
+  void ZoomChangedForActiveTab(bool can_show_bubble) override;
+  gfx::Rect GetRestoredBounds() const override;
+  ui::WindowShowState GetRestoredState() const override;
+  gfx::Rect GetBounds() const override;
+  bool IsMaximized() const override;
+  bool IsMinimized() const override;
+  void Maximize() override;
+  void Minimize() override;
+  void Restore() override;
+  void EnterFullscreen(const GURL& url,
+                       FullscreenExitBubbleType bubble_type) override;
+  void ExitFullscreen() override;
+  void UpdateFullscreenExitBubbleContent(
       const GURL& url,
       FullscreenExitBubbleType bubble_type) override;
-  virtual bool ShouldHideUIForFullscreen() const override;
-  virtual bool IsFullscreen() const override;
-  virtual bool IsFullscreenBubbleVisible() const override;
+  bool ShouldHideUIForFullscreen() const override;
+  bool IsFullscreen() const override;
+  bool IsFullscreenBubbleVisible() const override;
 #if defined(OS_WIN)
   virtual void SetMetroSnapMode(bool enable) override;
   virtual bool IsInMetroSnapMode() const override;
 #endif
-  virtual LocationBar* GetLocationBar() const override;
-  virtual void SetFocusToLocationBar(bool select_all) override;
-  virtual void UpdateReloadStopState(bool is_loading, bool force) override;
-  virtual void UpdateToolbar(content::WebContents* contents) override;
-  virtual void FocusToolbar() override;
-  virtual void FocusAppMenu() override;
-  virtual void FocusBookmarksToolbar() override;
-  virtual void FocusInfobars() override;
-  virtual void RotatePaneFocus(bool forwards) override;
-  virtual void DestroyBrowser() override;
-  virtual bool IsBookmarkBarVisible() const override;
-  virtual bool IsBookmarkBarAnimating() const override;
-  virtual bool IsTabStripEditable() const override;
-  virtual bool IsToolbarVisible() const override;
-  virtual gfx::Rect GetRootWindowResizerRect() const override;
-  virtual void ConfirmAddSearchProvider(TemplateURL* template_url,
-                                        Profile* profile) override;
-  virtual void ShowUpdateChromeDialog() override;
-  virtual void ShowBookmarkBubble(const GURL& url,
-                                  bool already_bookmarked) override;
-  virtual void ShowBookmarkAppBubble(
-      const WebApplicationInfo& web_app_info,
-      const std::string& extension_id) override;
-  virtual void ShowTranslateBubble(
-      content::WebContents* contents,
-      translate::TranslateStep step,
-      translate::TranslateErrors::Type error_type,
-      bool is_user_gesture) override;
+  LocationBar* GetLocationBar() const override;
+  void SetFocusToLocationBar(bool select_all) override;
+  void UpdateReloadStopState(bool is_loading, bool force) override;
+  void UpdateToolbar(content::WebContents* contents) override;
+  void FocusToolbar() override;
+  void FocusAppMenu() override;
+  void FocusBookmarksToolbar() override;
+  void FocusInfobars() override;
+  void RotatePaneFocus(bool forwards) override;
+  void DestroyBrowser() override;
+  bool IsBookmarkBarVisible() const override;
+  bool IsBookmarkBarAnimating() const override;
+  bool IsTabStripEditable() const override;
+  bool IsToolbarVisible() const override;
+  gfx::Rect GetRootWindowResizerRect() const override;
+  void ConfirmAddSearchProvider(TemplateURL* template_url,
+                                Profile* profile) override;
+  void ShowUpdateChromeDialog() override;
+  void ShowBookmarkBubble(const GURL& url, bool already_bookmarked) override;
+  void ShowBookmarkAppBubble(const WebApplicationInfo& web_app_info,
+                             const std::string& extension_id) override;
+  void ShowTranslateBubble(content::WebContents* contents,
+                           translate::TranslateStep step,
+                           translate::TranslateErrors::Type error_type,
+                           bool is_user_gesture) override;
 #if defined(ENABLE_ONE_CLICK_SIGNIN)
-  virtual void ShowOneClickSigninBubble(
+  void ShowOneClickSigninBubble(
       OneClickSigninBubbleType type,
       const base::string16& email,
       const base::string16& error_message,
@@ -331,123 +328,119 @@ class BrowserView : public BrowserWindow,
 #endif
   // TODO(beng): Not an override, move somewhere else.
   void SetDownloadShelfVisible(bool visible);
-  virtual bool IsDownloadShelfVisible() const override;
-  virtual DownloadShelf* GetDownloadShelf() override;
-  virtual void ConfirmBrowserCloseWithPendingDownloads(
+  bool IsDownloadShelfVisible() const override;
+  DownloadShelf* GetDownloadShelf() override;
+  void ConfirmBrowserCloseWithPendingDownloads(
       int download_count,
       Browser::DownloadClosePreventionType dialog_type,
       bool app_modal,
       const base::Callback<void(bool)>& callback) override;
-  virtual void UserChangedTheme() override;
-  virtual int GetExtraRenderViewHeight() const override;
-  virtual void WebContentsFocused(content::WebContents* contents) override;
-  virtual void ShowWebsiteSettings(Profile* profile,
-                                   content::WebContents* web_contents,
-                                   const GURL& url,
-                                   const content::SSLStatus& ssl) override;
-  virtual void ShowAppMenu() override;
-  virtual bool PreHandleKeyboardEvent(
-      const content::NativeWebKeyboardEvent& event,
-      bool* is_keyboard_shortcut) override;
-  virtual void HandleKeyboardEvent(
+  void UserChangedTheme() override;
+  int GetExtraRenderViewHeight() const override;
+  void WebContentsFocused(content::WebContents* contents) override;
+  void ShowWebsiteSettings(Profile* profile,
+                           content::WebContents* web_contents,
+                           const GURL& url,
+                           const content::SSLStatus& ssl) override;
+  void ShowAppMenu() o…
(message too large)

[commit-bot: I haz the power, 2014-10-28 00:55:09]

The CQ bit was unchecked by commit-bot@chromium.org

[dcheng, 2014-10-28 06:53:17]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-10-28 06:54:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/686463004/20001

[commit-bot: I haz the power, 2014-10-28 07:51:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-28 07:51:51]

Patchset 2 (id:??) landed as
https://crrev.com/2227fcd59e80b184db6223735d018a62445a29c9
Cr-Commit-Position: refs/heads/master@{#301590}