chrome/browser/ui/views/frame/browser_non_client_frame_view.h - Issue 686463004: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_non_client_frame_view.h

Issue 686463004: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/browser_header_painter_ash.h ('k') | chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_non_client_frame_view.h

diff --git a/chrome/browser/ui/views/frame/browser_non_client_frame_view.h b/chrome/browser/ui/views/frame/browser_non_client_frame_view.h

index 832ec385747704cc93cea3c468d0d858facfe294..5520abb940432e7d13603620dc351ab0dac25c2e 100644

--- a/chrome/browser/ui/views/frame/browser_non_client_frame_view.h

+++ b/chrome/browser/ui/views/frame/browser_non_client_frame_view.h

@@ -22,7 +22,7 @@ class BrowserNonClientFrameView : public views::NonClientFrameView,

public ProfileInfoCacheObserver {

public:

BrowserNonClientFrameView(BrowserFrame* frame, BrowserView* browser_view);

- virtual ~BrowserNonClientFrameView();

+ ~BrowserNonClientFrameView() override;

AvatarMenuButton* avatar_button() const { return avatar_button_; }

@@ -33,7 +33,7 @@ class BrowserNonClientFrameView : public views::NonClientFrameView,

return supervised_user_avatar_label_;

}

- virtual void OnThemeChanged() override;

+ void OnThemeChanged() override;

#endif

// Retrieves the bounds, in non-client view coordinates within which the

@@ -53,8 +53,7 @@ class BrowserNonClientFrameView : public views::NonClientFrameView,

virtual void UpdateThrobber(bool running) = 0;

// Overriden from views::View.

- virtual void VisibilityChanged(views::View* starting_from,

- bool is_visible) override;

+ void VisibilityChanged(views::View* starting_from, bool is_visible) override;

protected:

BrowserView* browser_view() const { return browser_view_; }