chrome/browser/ui/views/frame/immersive_mode_controller_stub.h - Issue 686463004: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/immersive_mode_controller_stub.h

Issue 686463004: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/immersive_mode_controller_ash.h ('k') | chrome/browser/ui/views/frame/opaque_browser_frame_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/immersive_mode_controller_stub.h

diff --git a/chrome/browser/ui/views/frame/immersive_mode_controller_stub.h b/chrome/browser/ui/views/frame/immersive_mode_controller_stub.h

index 83d757e8761e31a76cd3eaad77f98e2688c119a4..f7d0f3ee9fa7fdf8c26e1d969811bac1173dc02f 100644

--- a/chrome/browser/ui/views/frame/immersive_mode_controller_stub.h

+++ b/chrome/browser/ui/views/frame/immersive_mode_controller_stub.h

@@ -15,22 +15,22 @@

class ImmersiveModeControllerStub : public ImmersiveModeController {

public:

ImmersiveModeControllerStub();

- virtual ~ImmersiveModeControllerStub();

+ ~ImmersiveModeControllerStub() override;

// ImmersiveModeController overrides:

- virtual void Init(BrowserView* browser_view) override;

- virtual void SetEnabled(bool enabled) override;

- virtual bool IsEnabled() const override;

- virtual bool ShouldHideTabIndicators() const override;

- virtual bool ShouldHideTopViews() const override;

- virtual bool IsRevealed() const override;

- virtual int GetTopContainerVerticalOffset(

+ void Init(BrowserView* browser_view) override;

+ void SetEnabled(bool enabled) override;

+ bool IsEnabled() const override;

+ bool ShouldHideTabIndicators() const override;

+ bool ShouldHideTopViews() const override;

+ bool IsRevealed() const override;

+ int GetTopContainerVerticalOffset(

const gfx::Size& top_container_size) const override;

- virtual ImmersiveRevealedLock* GetRevealedLock(

- AnimateReveal animate_reveal) override WARN_UNUSED_RESULT;

- virtual void OnFindBarVisibleBoundsChanged(

+ ImmersiveRevealedLock* GetRevealedLock(AnimateReveal animate_reveal) override

+ WARN_UNUSED_RESULT;

+ void OnFindBarVisibleBoundsChanged(

const gfx::Rect& new_visible_bounds_in_screen) override;

- virtual void SetupForTest() override;

+ void SetupForTest() override;

private:

DISALLOW_COPY_AND_ASSIGN(ImmersiveModeControllerStub);