chrome/browser/ui/views/frame/browser_frame_ash.cc - Issue 686463004: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_frame_ash.cc

Issue 686463004: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/frame/browser_frame_ash.h ('k') | chrome/browser/ui/views/frame/browser_header_painter_ash.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_frame_ash.cc

diff --git a/chrome/browser/ui/views/frame/browser_frame_ash.cc b/chrome/browser/ui/views/frame/browser_frame_ash.cc

index 2c993031b431b1c02e319b11bbd1c4d076e2f0b2..9f576dc749cf90d357ece38af240f66bc538ad34 100644

--- a/chrome/browser/ui/views/frame/browser_frame_ash.cc

+++ b/chrome/browser/ui/views/frame/browser_frame_ash.cc

@@ -29,10 +29,10 @@ class BrowserWindowStateDelegate : public ash::wm::WindowStateDelegate {

: browser_(browser) {

DCHECK(browser_);

}

- virtual ~BrowserWindowStateDelegate(){}

+ ~BrowserWindowStateDelegate() override {}

// Overridden from ash::wm::WindowStateDelegate.

- virtual bool ToggleFullscreen(ash::wm::WindowState* window_state) override {

+ bool ToggleFullscreen(ash::wm::WindowState* window_state) override {

DCHECK(window_state->IsFullscreen() || window_state->CanMaximize());

// Windows which cannot be maximized should not be fullscreened.

if (!window_state->IsFullscreen() && !window_state->CanMaximize())

« no previous file with comments | « chrome/browser/ui/views/frame/browser_frame_ash.h ('k') | chrome/browser/ui/views/frame/browser_header_painter_ash.h » ('j') | no next file with comments »